Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug issue template - update installation methods #3974

Conversation

efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc commented Aug 29, 2023

Bug issue template - update installation methods

Pull Request Type

  • Other - Chore

Related issue

#3953

Description

I added (Unofficial) to the install methods this applies to.
This PR also reorders the installation methods and put the unofficial downloads under the official ones.
Added a description to let people know they have to try official installation before submitting the issue.
Changed the labeler workflow to support the new naming

Testing

  1. Go to https://github.com/efb4f5ff-1298-471a-8973-3d47447115dc/FreeTube/issues/new/choose
  2. Check if the description is there
  3. Check if the install methods are reordered in the dropdown
  4. Select one of the unofficial install methods
  5. Open issue
  6. Check if Unofficial label is being applied to the issue

If u dont want to file the issue to check if the label is applied u can also check out my testings

efb4f5ff-1298-471a-8973-3d47447115dc#49
efb4f5ff-1298-471a-8973-3d47447115dc#48
efb4f5ff-1298-471a-8973-3d47447115dc#47
efb4f5ff-1298-471a-8973-3d47447115dc#46

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) August 29, 2023 20:15
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Aug 29, 2023
@@ -2,7 +2,7 @@
- '(visual bug)'

'B: Unofficial Download':
- '(AUR|Chocolatey|FreeTubeCordova|PortableApps|winget|Scoop|Snapcraft|MPR|Nix)'
- '(AUR \(Unofficial\)|Chocolatey \(Unofficial\)|\.apk \(Android, FreeTubeCordova Unofficial\)|PortableApps \(Unofficial\)|winget \(Unofficial\)|Scoop \(Unofficial\)|Snapcraft \(Unofficial\)|MPR \(Unofficial\)|Nix \(Unofficial\))'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a need to include (Unofficial) here? (Is this exact match not regex?)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I included this because in the past i have seen some people mentioning one of the install methods in the issue body but they had not selected it as install method.

This way somebody can mention AUR in the additional context of the issue body without the label being applied

@FreeTubeBot FreeTubeBot merged commit 1bcbb38 into FreeTubeApp:development Aug 31, 2023
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Aug 31, 2023
@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc deleted the unofficial-downloads branch August 31, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants