-
Notifications
You must be signed in to change notification settings - Fork 857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add identifiers to channels hidden by ID #4230
Add identifiers to channels hidden by ID #4230
Conversation
If this is merged should we change #4228 to hide channel by channel ID? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shorten the code a bit first?
src/renderer/components/ft-list-video-lazy/ft-list-video-lazy.js
Outdated
Show resolved
Hide resolved
src/renderer/components/ft-list-lazy-wrapper/ft-list-lazy-wrapper.js
Outdated
Show resolved
Hide resolved
src/renderer/components/distraction-settings/distraction-settings.js
Outdated
Show resolved
Hide resolved
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
Thank you. Works well. Here are few points for consideration:
Screen.Recording.2023-10-27.at.17.39.13.moveverything above is UI related only and you can argue either way, the underlying problem is fixed with this PR |
Screen.Recording.2023-10-27.at.18.17.34.movEDIT However, this seems to have been a one-time issue as the image now displays correctly. |
@LangLangBart When you are editing the files on disk, make sure FreeTube is completely closed. Maybe it's time we add a lock on those files while FreeTube is running, so people stop editing them while FreeTube is running and wondering why stuff breaks. |
Updated it to just show the channel name. Need suggestions on handling already blocked channels using ID. Like to do it automatically once on startup or have some button for the user to update them. |
@Benjababe The blocking should be done using the channel ID, that way it will still work when the channel name changes. |
2d177bb
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
My bad, forgot to check for tags without icons |
* development: (24 commits) Translated using Weblate (Arabic) Translated using Weblate (Ukrainian) Translated using Weblate (Polish) Translated using Weblate (French) Translated using Weblate (Greek) Translated using Weblate (Russian) Add missing Electron guards after FreeTubeApp#4230 (FreeTubeApp#4311) Translated using Weblate (Turkish) Translated using Weblate (Chinese (Traditional)) Translated using Weblate (Portuguese) Translated using Weblate (Croatian) video id hash length to 4 (FreeTubeApp#4313) Translated using Weblate (Spanish) Translated using Weblate (Serbian) Translated using Weblate (Czech) Translated using Weblate (Italian) Translated using Weblate (Chinese (Simplified)) Add identifiers to channels hidden by ID (FreeTubeApp#4230) Translated using Weblate (Japanese) Fixed order of elements to allow for proper tabbing in comments section (FreeTubeApp#4099) ...
* add description option to hiding channels * does channel id search * add tag tooltip * legacy support for hidden channels * update removeTag * add parenthesis to id name * add icon and id checking before requesting * update id regex * decouple channel hidden from tags * update handling for legacy hidden channels * remove tag description * formatting * newline * shorten retrieving hidden channels * separate channel api requests * refractor ft-input-tags.js * replace secondaryName with preferredName for tags * unify hidden channel name/icon retrieval function * remove tooltip from ft-input-tags * auto update hidden channel if ID was used * remove hiding channel by name * i18n channels hidden disabled message * run auto hidden channel id update once * Update src/renderer/components/ft-input-tags/ft-input-tags.vue Co-authored-by: Jason <[email protected]> * add text selection for ft tags * add ft-input-tags icon url * fix icon link --------- Co-authored-by: Jason <[email protected]>
* Add missing Electron guards after FreeTubeApp#4230 * Fix logic issue
* development: (24 commits) Translated using Weblate (Arabic) Translated using Weblate (Ukrainian) Translated using Weblate (Polish) Translated using Weblate (French) Translated using Weblate (Greek) Translated using Weblate (Russian) Add missing Electron guards after FreeTubeApp#4230 (FreeTubeApp#4311) Translated using Weblate (Turkish) Translated using Weblate (Chinese (Traditional)) Translated using Weblate (Portuguese) Translated using Weblate (Croatian) video id hash length to 4 (FreeTubeApp#4313) Translated using Weblate (Spanish) Translated using Weblate (Serbian) Translated using Weblate (Czech) Translated using Weblate (Italian) Translated using Weblate (Chinese (Simplified)) Add identifiers to channels hidden by ID (FreeTubeApp#4230) Translated using Weblate (Japanese) Fixed order of elements to allow for proper tabbing in comments section (FreeTubeApp#4099) ...
* development: (24 commits) Translated using Weblate (Arabic) Translated using Weblate (Ukrainian) Translated using Weblate (Polish) Translated using Weblate (French) Translated using Weblate (Greek) Translated using Weblate (Russian) Add missing Electron guards after FreeTubeApp#4230 (FreeTubeApp#4311) Translated using Weblate (Turkish) Translated using Weblate (Chinese (Traditional)) Translated using Weblate (Portuguese) Translated using Weblate (Croatian) video id hash length to 4 (FreeTubeApp#4313) Translated using Weblate (Spanish) Translated using Weblate (Serbian) Translated using Weblate (Czech) Translated using Weblate (Italian) Translated using Weblate (Chinese (Simplified)) Add identifiers to channels hidden by ID (FreeTubeApp#4230) Translated using Weblate (Japanese) Fixed order of elements to allow for proper tabbing in comments section (FreeTubeApp#4099) ...
Add identifiers to channels hidden by ID
Pull Request Type
Related issue
Closes #4181
Description
If a channel ID is provided (checks for
UC
at start and is 24 characters long), searches invidious or local API for the channel name and thumbnail and stores them.If users have existing IDs hidden, when entering the settings page it will automatically try to update it with a channel name and icon.
Removed ability to hide by channel name, does a ID check ("UC"+22chars) on entry. Invalid IDs may pass but it'll stop on an API error for channel info retrieval
Also added link in the icon that goes to the creator's channel.
Screenshots
1.mp4
Had to use setTimeout to see how the UI updates as each channel gets updated. In practice, it's pretty instantaneous.
test-auto-update.mp4
Testing
Tried with
Desktop