Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "app start in fullscreen" #5639

Closed
wants to merge 1 commit into from
Closed

Conversation

iacore
Copy link

@iacore iacore commented Sep 2, 2024

This fixes #3220 but breaks window position memory.

I don't need the app to remember the window position, since I use a tiling window manager.

A more realistic fix:

Probably don't need to save {fullscreen: true, maximized: true} inside value

@iacore iacore changed the title Fix #3220 "Fix" #3220 Sep 2, 2024
@iacore iacore changed the title "Fix" #3220 Fix "app start in fullscreen" Sep 2, 2024
@iacore iacore marked this pull request as ready for review September 2, 2024 17:04
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) September 2, 2024 17:04
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Sep 2, 2024
@absidue
Copy link
Member

absidue commented Sep 2, 2024

As this "fixes" the issue by breaking loads of other things, this is definitely the wrong approach. Removing functionality that many users like just because you personally don't need it is something you can do in custom builds for yourself but not in the main repo for a project like FreeTube.

Closing this in favour of #5138
If you still want to help, please provide suggestions on that existing pull request, which tries to fix it in a much less destructive way.

@absidue absidue closed this Sep 2, 2024
auto-merge was automatically disabled September 2, 2024 20:56

Pull request was closed

@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: FreeTube starts fullsrceen, and the "fullscreen" button cannot toggle between fullscreen modes
2 participants