Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump shaka-player from 4.10.12 to 4.11.1 #5677

Merged
merged 6 commits into from
Sep 15, 2024
Merged

Bump shaka-player from 4.10.12 to 4.11.1 #5677

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
dc4c5a5
Bump shaka-player from 4.10.12 to 4.11.1
dependabot[bot] Sep 9, 2024
69c49a8
Remove position state and action handler media session code as shaka-…
absidue Sep 9, 2024
ea5ea7c
Remove legacy subtitles code as shaka-player now handles that itself
absidue Sep 9, 2024
0898365
Fix buggy live streams
absidue Sep 9, 2024
d86a387
Fix auto-generated subtitle positioning with the legacy formats again
absidue Sep 9, 2024
6afc0dc
Hide seek bar for live streams
absidue Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
"path-browserify": "^1.0.1",
"portal-vue": "^2.1.7",
"process": "^0.11.10",
"shaka-player": "^4.10.12",
"shaka-player": "^4.11.1",
"swiper": "^11.1.12",
"vue": "^2.7.16",
"vue-i18n": "^8.28.2",
Expand Down
10 changes: 0 additions & 10 deletions src/renderer/components/ft-shaka-video-player/ft-shaka-video-player.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,16 +37,6 @@
flex-direction: column-reverse;
}

/*
With the legacy formats, shaka hands over the captions to the browser,
that causes issues like the captions being displayed under the player controls.
The browser positions captions based on the video element as it doesn't know about shaka's custom controls.
To solve that we use shaka's caption displayer (UITextDisplayer), so we need to hide the browser's ones
*/
.player::-webkit-media-text-track-container {
display: none;
}

.sixteenByNine {
aspect-ratio: 16 / 9;
}
Expand Down
Loading