Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support copying post links from the context menu #5760

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

absidue
Copy link
Member

@absidue absidue commented Sep 28, 2024

Support copying post links from the context menu

Pull Request Type

  • Feature Implementation

Description

This pull request adds support for copying in-app post links with the context menu. In the future it might make sense to add the share button to the post page, but I wasn't sure how to fit it into the UI, so I decided that it could be done in a future pull request.

Screenshots

Before:
before

After:
after

Testing

  1. Visit https://www.youtube.com/@YouTube/community
  2. Right click on the comment icon
  3. Test that the produced links are valid by opening the links in your browser or inside FreeTube

Desktop

  • OS: Windows
  • OS Version: 10
  • FreeTube version: 4503ff1

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) September 28, 2024 14:11
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Sep 28, 2024
@FreeTubeBot FreeTubeBot merged commit d12901a into FreeTubeApp:development Sep 30, 2024
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Sep 30, 2024
@absidue absidue deleted the copy-post-link branch September 30, 2024 05:04
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request Oct 3, 2024
* development: (49 commits)
  Translated using Weblate (Japanese)
  Translated using Weblate (French)
  Fix long comments overflowing and breaking the layout (FreeTubeApp#5774)
  Cleanup unused code in the store (FreeTubeApp#5776)
  Revert "Larger search/URL bar (FreeTubeApp#5348)" (FreeTubeApp#5773)
  Fix loading from search cache failing when no features are selected (FreeTubeApp#5775)
  Bump lefthook from 1.7.15 to 1.7.17 (FreeTubeApp#5768)
  Bump webpack from 5.94.0 to 5.95.0 (FreeTubeApp#5770)
  Bump sass from 1.79.3 to 1.79.4 (FreeTubeApp#5771)
  Translated using Weblate (Chinese (Traditional Han script))
  Change the Proxy Videos Through Invidious setting to only apply when using the Invidious API (FreeTubeApp#5758)
  Support copying post links from the context menu (FreeTubeApp#5760)
  Local API: Fix error when a community post has no likes (FreeTubeApp#5759)
  Translated using Weblate (English (United Kingdom))
  Translated using Weblate (Dutch)
  Translated using Weblate (Swedish)
  Do not overwrite cache entries when hitting RSS ratelimits (FreeTubeApp#5756)
  Translated using Weblate (Czech)
  Translated using Weblate (Hungarian)
  Translated using Weblate (Hungarian)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants