Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix long comments overflowing and breaking the layout #5774

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Fix long comments overflowing and breaking the layout #5774

merged 1 commit into from
Oct 1, 2024
+1 −1

Conversation

absidue
Copy link
Member

@absidue absidue commented Sep 30, 2024

Fix long comments overflowing and breaking the layout

Pull Request Type

  • Bugfix

Related issue

closes #5296

Description

This pull requests fixes comments with long "words" overflowing horizontally and breaking the layout. It looks like we had some existing code which was supposed to fix that but that didn't seem to be doing anything anymore.

Screenshots

Before:
before

After:
after

Testing

  1. Turn on Hide Recommended Videos in the Distraction Free Settings
  2. Open the video provided in the linked bug report: https://youtu.be/ASeJV9KGAOc
  3. Load the comments
  4. Check that they don't break the layout anymore.

Desktop

  • OS: Windows
  • OS Version: 10
  • FreeTube version: b3f92e3

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Sep 30, 2024
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) September 30, 2024 16:03
@FreeTubeBot FreeTubeBot merged commit 6f53def into FreeTubeApp:development Oct 1, 2024
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Oct 1, 2024
@absidue absidue deleted the comment-overflow branch October 1, 2024 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PikachuEXE PikachuEXE PikachuEXE approved these changes

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc approved these changes

@ChunkyProgrammer ChunkyProgrammer ChunkyProgrammer approved these changes

@kommunarr kommunarr Awaiting requested review from kommunarr

@MarmadileManteater MarmadileManteater Awaiting requested review from MarmadileManteater

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Long comments overflow
5 participants
@absidue @PikachuEXE @efb4f5ff-1298-471a-8973-3d47447115dc @ChunkyProgrammer @FreeTubeBot