Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loading from search cache failing when no features are selected #5775

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

absidue
Copy link
Member

@absidue absidue commented Sep 30, 2024

Fix loading from search cache failing when no features are selected

Pull Request Type

  • Bugfix

Related issue

closes #5305

Description

When no features are selected and you return to the search page again, it was treating them as undefined, this caused the search cache checks to fail as they were comparing undefined against an empty array, so it then tried to make an API request to Invidious but that function expects the features to always be an array, so it was throwing an error about calling join() on undefined. This pull request makes sure that the features are set to an empty array if none are provided, which fixes the search cache look ups and makes the Invidious search happy because it will always receive an array.

Screenshots

error

Testing

  1. Set the preferred API backend to Invidious
  2. Search for something e.g. linus tech tips
  3. Press the back arrow in the navigation bar
  4. Press the forward arrow in the navigation bar
  5. It should have correctly restored the search results from the search cache without erroring or trying to make a new API request

Desktop

  • OS:
  • OS Version:
  • FreeTube version: b3f92e3

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Sep 30, 2024
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) September 30, 2024 16:31
@FreeTubeBot FreeTubeBot merged commit bb54eb2 into FreeTubeApp:development Oct 1, 2024
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Oct 1, 2024
@absidue absidue deleted the iv-search-page branch October 1, 2024 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Infinite hang on "loading" screen when pressing back/forward buttons with the Invidious API
5 participants