Fix some undesired attributes being saved to playlists.db #5900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
added
the
DO NOT MERGE UNTIL AFTER RELEASE
ChunkyProgrammer
removed
the
DO NOT MERGE UNTIL AFTER RELEASE
auto-merge was automatically disabled
October 27, 2024 08:34
Head branch was pushed to by a user without write access
TheodorSmall
force-pushed
the
playlist-undesired-attributes
branch
from
4d6ca26
to
01fdd88
Compare
efb4f5ff-1298-471a-8973-3d47447115dc
requested review from
PikachuEXE and
absidue
PikachuEXE
approved these changes
Oct 29, 2024
absidue
approved these changes
Oct 29, 2024
kommunarr
approved these changes
Oct 29, 2024
github-actions
bot
removed
the
PR: waiting for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some undesired attributes being saved to playlists.db
Pull Request Type
Related issue
closes #5601
Description
With Invidious API, certain undesired attributes of videos are fetched when copying playlists. There's already an implementation to get rid of those (in src/renderer/store/modules/playlists.js:actions.getVideos), but the list of those attributes is currently incomplete. The following attributes are missing in the list (relying on the fact that they are not saved when adding videos one by one):
Testing
Tested for both development mode and production mode.
With Invidious API enabled, add a playlist from YT to a local playlist, and add some videos one by one to another local playlist.
Then check that the attribute names of the videos are the same in both playlists.
There is no need to close FT before reading playlists.db if you make sure you are looking at the most up-to-date version of the playlist (which is the last line with the playlist with that name).
Desktop