Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invidious API: Add support for auto-dubbed audio tracks #5943

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Invidious API: Add support for auto-dubbed audio tracks #5943

merged 2 commits into from
Oct 29, 2024

Conversation

absidue
Copy link
Member

@absidue absidue commented Oct 26, 2024 •
edited
Loading

Invidious API: Add support for auto-dubbed audio tracks

Pull Request Type

  • Bugfix
  • Feature Implementation

Related issue

LuanRT/YouTube.js#786

Description

YouTube has added a feature for uploaders to tell YouTube to automatically generate dubbed audio tracks for their videos. Support for the local API is handled in the linked YouTube.js pull request, this pull request implements it for the Invidious backend, as we handle multiple audio tracks support for Invidious in the FreeTube code (because Invidious doesn't support them itself yet).

Testing

Check that the player selects the original audio track by default and that you can use some of the other audio tracks.
Test video: https://youtu.be/snZ9w5xc_ic (thanks to the users in the Invidious Matrix chat for mentioning a channel that has those types of audio tracks)

Desktop

  • OS: Windows
  • OS Version: 10
  • FreeTube version: eaef9a0

@absidue absidue marked this pull request as ready for review October 28, 2024 18:29
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Oct 28, 2024
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) October 28, 2024 18:29
efb4f5ff-1298-471a-8973-3d47447115dc
efb4f5ff-1298-471a-8973-3d47447115dc reviewed Oct 28, 2024
View reviewed changes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isnt this labeling a bit weird? Also it doesnt look to be sorted a-z?

VirtualBoxVM_csM09iqsJ6.mp4

@absidue
Copy link
Member Author

absidue commented Oct 28, 2024

Pretty sure we've never done any sorting on the audio tracks on either API, we just display them in the order that they came in the API response.

As for the labels I can force it to always use the language (region) format for the labels that we create for the Invidious API, so it matches the labels for the local API that are returned by YouTube.

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

Pretty sure we've never done any sorting on the audio tracks on either API, we just display them in the order that they came in the API response.

Ah okay good to know. Please disregard my comment.

As for the labels I can force it to always use the language (region) format for the labels that we create for the Invidious API, so it matches the labels for the local API that are returned by YouTube.

Yes lets do that for the sake of uniformity

@absidue
Copy link
Member Author

absidue commented Oct 28, 2024

Updated the display names to always be in the language (region) format.

@FreeTubeBot FreeTubeBot merged commit 2ef30ef into FreeTubeApp:development Oct 29, 2024
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Oct 29, 2024
PikachuEXE added a commit to Zeabyte/FreeTube-0 that referenced this pull request Oct 29, 2024
@PikachuEXE
Merge branch 'development' into Zeabyte/development
d882071 
* development: (225 commits)
  Invidious API: Add support for auto-dubbed audio tracks (FreeTubeApp#5943)
  Fix settings password handling (FreeTubeApp#5988)
  Translated using Weblate (Serbian)
  Translated using Weblate (Breton)
  Translated using Weblate (Toki Pona)
  Translated using Weblate (Breton)
  Translated using Weblate (Toki Pona)
  Translated using Weblate (Icelandic)
  Bump youtubei.js from 10.5.0 to 11.0.0 (FreeTubeApp#5996)
  Bump shaka-player from 4.11.10 to 4.11.11 (FreeTubeApp#5995)
  Bump eslint-plugin-vue from 9.29.1 to 9.30.0 in the eslint group (FreeTubeApp#5994)
  Translated using Weblate (Latvian)
  Translated using Weblate (Toki Pona)
  Translated using Weblate (Icelandic)
  Translated using Weblate (Hungarian)
  Translated using Weblate (Toki Pona)
  Translated using Weblate (Icelandic)
  Translated using Weblate (Hungarian)
  Migrate FtListChannel and FtListHashtag to the composition API (FreeTubeApp#5945)
  Fix issue FreeTubeApp#5969 (FreeTubeApp#5970)
  ...
@absidue absidue deleted the auto-dubbed-audio branch October 29, 2024 06:41
@absidue absidue mentioned this pull request Oct 30, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChunkyProgrammer ChunkyProgrammer ChunkyProgrammer approved these changes

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc approved these changes

@PikachuEXE PikachuEXE PikachuEXE approved these changes

@kommunarr kommunarr Awaiting requested review from kommunarr

@MarmadileManteater MarmadileManteater Awaiting requested review from MarmadileManteater

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@absidue @efb4f5ff-1298-471a-8973-3d47447115dc @PikachuEXE @ChunkyProgrammer @FreeTubeBot