Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invidious API: Extract streaming data expiry date from URL #5997

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Invidious API: Extract streaming data expiry date from URL #5997

merged 1 commit into from
Oct 29, 2024

Conversation

absidue
Copy link
Member

@absidue absidue commented Oct 28, 2024

Invidious API: Extract streaming data expiry date from URL

Pull Request Type

  • Bugfix

Related issue

Related to #5991

Description

This fixes FreeTube claiming that the streaming data has expired when a 403 happens with the Invidious API even when it hasn't expired.

Testing

  1. Add a console.log(this.streamingDataExpiryDate) line below the this.streamingDataExpiryDate = line
  2. Launch FreeTube
  3. Set the backend to Invidious
  4. Open a video
  5. Check the console and check that the date is in the future (it should be multiple hours in the future).

Desktop

  • OS: Windows
  • OS Version: 10
  • FreeTube version: 6d10110

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Oct 28, 2024
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) October 28, 2024 18:03
@FreeTubeBot FreeTubeBot merged commit 80be9ae into FreeTubeApp:development Oct 29, 2024
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Oct 29, 2024
@absidue absidue deleted the iv-expiry-date branch October 29, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kommunarr kommunarr kommunarr approved these changes

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc approved these changes

@PikachuEXE PikachuEXE PikachuEXE approved these changes

@ChunkyProgrammer ChunkyProgrammer Awaiting requested review from ChunkyProgrammer

@MarmadileManteater MarmadileManteater Awaiting requested review from MarmadileManteater

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@absidue @PikachuEXE @efb4f5ff-1298-471a-8973-3d47447115dc @kommunarr @FreeTubeBot