Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Big Play Button smaller #6002

Conversation

ChunkyProgrammer
Copy link
Member

Make Big Play Button smaller

Pull Request Type

  • Other - visual improvement

Related issue

closes #5951

Description

This PR adds some transparency to the Big Play Button and adds a max size for it (110px x 110px).

Screenshots (from 22 inch monitor)

Before:
Normal mode:
image
Theater Mode:
image

After:
Normal mode:
image
Theater mode (the button is the same size but it might look smaller on GitHub since the screenshot is larger):
image

Testing

  • I was able to test this on a 22inch monitor, 24inch monitor and 64 inch TV but the TV was zoomed in to 200%. It looked good on these monitors. I'd recommend testing with large monitors (smaller monitors/phones should be fine/the same).

Desktop

  • OS: Linux Mint 22
  • OS Version: 22
  • FreeTube version: latest nightly

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Oct 28, 2024
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) October 28, 2024 22:56
@efb4f5ff-1298-471a-8973-3d47447115dc

Maybe unrelated but what were the dimensions of the pre v0.22.0 button?

@kommunarr
Copy link
Collaborator

@kommunarr
Copy link
Collaborator

It's also worth noting that YT does not have this feature on either web or their mobile app. Maybe we change the default setting? Fine for keeping that discussion & implementation to a separate one-line PR if desired, though

@PikachuEXE
Copy link
Collaborator

Oh default value is on?
I guess this is from the player we use not from YT
If auto play video is on by default the big button seems not so useful?

@ChunkyProgrammer
Copy link
Member Author

By default in shaka-player, the big play button only appears for mobile users. I'm okay with changing the default to off. @MarmadileManteater you may want to keep it on for FreeTubeAndroid.

@absidue
Copy link
Member

absidue commented Oct 29, 2024

@kommunarr I'm slightly confused what you mean by YouTube's mobile app doesn't have this, because from what I can tell it definitely does:
image

@kommunarr
Copy link
Collaborator

@absidue On second check, you're correct, it does have it, but the overlay dismisses itself on clicking the player. My mistake

@kommunarr
Copy link
Collaborator

non-blocking: I'd like to see what it would look like at the v0.21 0.45 opacity

@ChunkyProgrammer
Copy link
Member Author

non-blocking: I'd like to see what it would look like at the v0.21 0.45 opacity

0.45:
image

0.75:
image

@kommunarr
Copy link
Collaborator

I prefer the lower opacity just because it only really matters if it's visible at all versus not. Will go with whichever one the team prefers.

@PikachuEXE
Copy link
Collaborator

Ask #5951 guys?

@FreeTubeBot FreeTubeBot merged commit a84d550 into FreeTubeApp:development Nov 10, 2024
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Nov 10, 2024
@Pentaphon
Copy link

I like the 0.45 opacity setting. The play button should be there but it should feel small and out of the way and lower opacity helps with that.

@ChunkyProgrammer ChunkyProgrammer deleted the make-player-button-smaller branch November 10, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Make huge play button in 0.22 Beta smaller on desktop
7 participants