Add support for hms timestamp in query string #6012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: waiting for review
absidue
reviewed
Oct 29, 2024
absidue
reviewed
Oct 29, 2024
PikachuEXE
approved these changes
Oct 30, 2024
kommunarr
approved these changes
Oct 30, 2024
absidue
approved these changes
Oct 30, 2024
github-actions
bot
removed
the
PR: waiting for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for hms timestamp in query string
Pull Request Type
Related issue
closes #6008
Description
Adds support for alternate timestamp urls.
Testing (i think it might subtracts 2 seconds from it)
go to https://youtu.be/27iu423Yjtc?t=2h10m20s
make sure it goes to 2 hours 10 minutes and 20 seconds
go to https://youtu.be/27iu423Yjtc?t=3h
make sure it goes to 3 hour mark
go to https://youtu.be/27iu423Yjtc?t=15m
make sure it goes to 15 minute mark
go to https://youtu.be/27iu423Yjtc?t=40s
make sure it goes to 40 second mark
go to https://youtu.be/27iu423Yjtc?t=45
make sure it goes to 45 second mark
Desktop