feat: added custom settings section #215
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frezyx
added
awaiting
|
Is there anything I can do to be able to merge this? |
|
I would love to see this merged as well. Failing this merge, I would love some small changes to the pub. I finally figured out that I can not do an easy override of the talker_settings_bottom_sheet because you don't export TalkerSettingCard, your Talker-specific BaseBottomSheet, and your TalkerBaseCard IF you exported those three classes, maybe even renaming BaseBottomSheet to TalkerBaseBottomSheet - then it would be trivial to extend your TalkerSettingsBottomSheet and override the build() function to add my own app-specific settings! |
|
@Frezyx would you like me to fix conflicts so this PR can be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows users to add custom settings to the talker settings page.
These custom settings are not managed or stored by talker but are just displayed on the settings page. The settings can be grouped into groups and each group can be enabled or disabled.
I understand if you decide not to merge this because it is a bit out of scope for collecting logs, but it is super helpful for me, as I prefer to have just one place to all debug related things, I'm using it in multiple apps and thought I'll share it.
Thank you for developing and maintaining this great package :)