Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hidden buttons don't process taps. #30

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

apozdeyev
Copy link

This pull-request contains fix of problem that hidden buttons can be tapped.

@ankraft
Copy link

ankraft commented Aug 14, 2016

I can confirm that this PR solves the problem for my app.
Would it be possible to accept the PR so that it is available in the master branch?

@aryosanjaya
Copy link

I do the similiar modification by set its "enabled" to YES/NO besides on "showing" YES/NO, to prevents user from accidentally click the invisible button.

But apozdeyev's fix is more simpler :)
Better to merge it.

Fix crash due to the KVO when we remove the superview instance, and create a new instance
@daniestrella1
Copy link

Working for me too. Good fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants