fix: frontend error when request includes don't have recipientUsers (…

…#209) * chore: yarn upgrade * fix: frontend error when includes dont have recipientUsers
FriendsOfFlarum · Dec 1, 2024 · 62513f4 · 62513f4
1 parent 74821ed
commit 62513f4
Show file tree

Hide file tree

Showing 2 changed files with 872 additions and 1,044 deletions.
diff --git a/js/src/forum/extenders/Discussion.js b/js/src/forum/extenders/Discussion.js
@@ -26,11 +26,11 @@ export default () => {
 const add = function (discussion, items, long) {
   let recipients = [];
 
-  if (discussion.recipientUsers().length) {
+  if (discussion.recipientUsers?.().length) {
     recipients = recipients.concat(discussion.recipientUsers());
   }
 
-  if (discussion.recipientGroups().length) {
+  if (discussion.recipientGroups?.().length) {
     recipients = recipients.concat(discussion.recipientGroups());
   }
 
@@ -125,7 +125,7 @@ function controls() {
         )
       );
     }
-    if (discussion && discussion.recipientUsers().find((user) => user?.id() === app.session.user?.id())) {
+    if (discussion && discussion.recipientUsers?.().find?.((user) => user?.id() === app.session.user?.id())) {
       items.add(
         'remove',
         Button.component(