Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: prepare dist-typings #89

Merged
merged 11 commits into from
Nov 2, 2024
Merged

chore: prepare dist-typings #89

merged 11 commits into from
Nov 2, 2024

Conversation

DavideIadeluca
Copy link
Member

Fixes #0000

Changes proposed in this pull request:

Reviewers should focus on:

Screenshot

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).

Required changes:

@DavideIadeluca DavideIadeluca marked this pull request as ready for review October 27, 2024 15:05
Copy link
Member

@imorland imorland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of quite minor points, overall is good tho!

@DavideIadeluca DavideIadeluca merged commit 4d496e7 into master Nov 2, 2024
8 checks passed
@DavideIadeluca DavideIadeluca deleted the di/dist-typings branch November 2, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants