Fix error when proxying a method with a mixed argument with a null default value #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah indeed, thanks |
|
Sure! I've changed the test to be a bit more specific (as the version requirements would probably be different for other data sets in the original data provider) and made the test skip in PHP < 8.0 (as mixed types were not possible in those versions). |
BrandonFlude
approved these changes
Mar 20, 2024
…fault value Without this change, trying to proxy a Symfony\Component\Console\Command\Command would result in an InvalidArgumentException `Type "mixed" cannot be nullable` from the Laminas code generator.
nicolas-grekas
force-pushed
the
mixed-arg-with-null-default-value
branch
2 times, most recently
from
239c53c
to
2c8a6cf
Compare
|
Thank you @aboks (please use spaces for your next PRs if any, that's the CS here ;) ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, trying to proxy a
Symfony\Component\Console\Command\Commandwould result in anInvalidArgumentExceptionType "mixed" cannot be nullablefrom the Laminas code generator. This is because of theaddArgumentmethod of theCommandclass having amixed $default = nullparameter. The error can be seen as a regression in 1.0.17 caused by #37.