golangci-lint

ci: add pipeline for macos and windows #437

Triggered via push November 3, 2023 00:53

shyim

pushed c02bb61

main

Status Failure

Total duration 56s

Artifacts –

lint.yml

on: push

lint

45s

Annotations

2 errors, 27 warnings, and 32 notices

lint: internal/git/git_test.go#L88

`runCommand` - `cmd` always receives `"git"` (unparam)

lint

issues found

Bool condition: cmd/project/project_proxy.go#L30

Condition `runtime.GOOS == "darwin"` is always `false`

Bool condition: internal/esbuild/sass.go#L63

Condition `osType == "darwin"` is always `false`

Bool condition: cmd/project/project_proxy.go#L32

Condition `runtime.GOOS == "windows"` is always `false`

Unexported return type of the exported function: extension/app.go#L291

Exported method with the unexported return type

Unexported return type of the exported function: extension/app.go#L287

Exported method with the unexported return type

Unexported return type of the exported function: extension/platform.go#L145

Exported method with the unexported return type

Unexported return type of the exported function: extension/bundle.go#L122

Exported method with the unexported return type

Unexported return type of the exported function: extension/platform.go#L157

Exported method with the unexported return type

Unexported return type of the exported function: extension/bundle.go#L134

Exported method with the unexported return type

Imported package name as a name identifier: cmd/project/ci.go#L237

Variable `extension` collides with imported package name

Imported package name as a name identifier: extension/project.go#L118

Variable `version` collides with imported package name

Imported package name as a name identifier: internal/esbuild/sass.go#L31

Variable `path` collides with imported package name

Imported package name as a name identifier: extension/project.go#L105

Variable `version` collides with imported package name

Imported package name as a name identifier: extension/project.go#L87

Variable `version` collides with imported package name

Imported package name as a name identifier: extension/validator.go#L47

Variable `context` collides with imported package name

Reserved word used as name: extension/platform.go#L275

Variable `error` collides with the 'builtin' interface

Unhandled error: internal/phplint/lint.go#L85

Unhandled error

Unhandled error: internal/phplint/lint.go#L82

Unhandled error

Unhandled error: account-api/login.go#L111

Unhandled error

Unhandled error: version/version.go#L368

Unhandled error

Unhandled error: internal/phplint/lint.go#L33

Unhandled error

Unhandled error: version/version.go#L363

Unhandled error

Unhandled error: version/version.go#L365

Unhandled error

Unhandled error: internal/esbuild/sass.go#L74

Unhandled error

Unused parameter: extension/bundle.go#L147

Unused parameter `ctx`

Unused parameter: extension/bundle.go#L147

Unused parameter `c`

Deprecated dependency: go.mod#L41

Deprecated module github.com/golang/protobuf

Comment of exported element starts with the incorrect name: internal/esbuild/util.go#L10

Comment should have the following format 'ToKebabCase ...' (with an optional leading article)

'defer' in the loop: extension/asset_platform.go#L94

Possible resource leak, `defer` is called in the `for` loop

'defer' in the loop: cmd/project/config_sync_theme.go#L39

Possible resource leak, `defer` is called in the `for` loop

'defer' in the loop: cmd/project/config_sync_entity.go#L41

Possible resource leak, `defer` is called in the `for` loop

'defer' in the loop: extension/asset_platform.go#L83

Possible resource leak, `defer` is called in the `for` loop

'defer' in the loop: cmd/project/config_sync_theme.go#L101

Possible resource leak, `defer` is called in the `for` loop

'defer' in the loop: extension/asset_platform.go#L106

Possible resource leak, `defer` is called in the `for` loop

Error string should not be capitalized or end with punctuation: cmd/account/account_producer_extension_info_push.go#L290

Error string should not be capitalized or end with punctuation mark

Error string should not be capitalized or end with punctuation: cmd/account/account_producer_extension_info_push.go#L303

Error string should not be capitalized or end with punctuation mark

Error string should not be capitalized or end with punctuation: version/version.go#L48

Error string should not be capitalized or end with punctuation mark

Error string should not be capitalized or end with punctuation: extension/zip.go#L75

Error string should not be capitalized or end with punctuation mark

Error string should not be capitalized or end with punctuation: version/version.go#L57

Error string should not be capitalized or end with punctuation mark

Name starts with a package name: internal/git/git.go#L12