Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: shopware messengers are orphaned on crash or SIGINT #394

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

pkramme
Copy link
Contributor

@pkramme pkramme commented Aug 1, 2024

This PR does a few things for the shopware-cli project worker command:

  • Shopware messengers are terminated with SIGKILL when shopware-cli terminates
  • SIGINT is now catched by the signal handler, so that you can ^C correctly
  • There is a new option --graceful-stop-limit, which signals messengers with SIGTERM and waits for a specified amount of time before using SIGKILL. When PCNTL is available in the messengers, this allows the messenger to finish handling their last message.
  • Crashes of shopware-cli are now (mostly, hopefully) prevented by instead restarting the workers. This better handles situations where one messenger crashes for some reason, which previously detached all other messengers from shopware-cli, creating storms of messengers overloading systems

@shyim shyim merged commit 55f0b12 into FriendsOfShopware:main Aug 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants