Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fail after 5 messages, add option to limit by message count #395

Merged
merged 1 commit into from
Aug 6, 2024
Merged

feat: fail after 5 messages, add option to limit by message count #395

merged 1 commit into from
Aug 6, 2024

Conversation

pkramme
Copy link
Contributor

@pkramme pkramme commented Aug 5, 2024

Hello,

this PR adds two new features:

  1. By default workers are killed after 5 failed messages by using the --failed-limit option
  2. --limit is passed through, if given

@pkramme
Copy link
Contributor Author

pkramme commented Aug 5, 2024 •
edited
Loading

@shyim I'm not actually sure whether there is a shopware version that doesn't support --limit or --failed-limit. It seems like early 6.4.x supports this, but I'm not sure about the earlier versions.

@shyim shyim merged commit 4117244 into FriendsOfShopware:main Aug 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shyim shyim shyim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pkramme @shyim