forked from doctrine/doctrine1
-
Notifications
You must be signed in to change notification settings - Fork 75
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix(migrations) Handle transaction within migrations
This fixes #98
- Loading branch information
Showing
6 changed files
with
127 additions
and
24 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
<?php | ||
|
||
/** | ||
* Helper for transactions handling. | ||
* | ||
* @author Kyle McGrogan <[email protected]> | ||
*/ | ||
final class Doctrine_TransactionHelper | ||
{ | ||
/** | ||
* Execute a commit on the given connection, only if a transaction already started. | ||
*/ | ||
public static function commitIfInTransaction(Doctrine_Connection $connection): void | ||
{ | ||
$handler = $connection->getDbh(); | ||
|
||
// Attempt to commit while no transaction is running results in exception since PHP 8 + pdo_mysql combination | ||
if ($handler instanceof PDO && !$handler->inTransaction()) { | ||
return; | ||
} | ||
|
||
$connection->commit(); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,68 @@ | ||
<?php | ||
/* | ||
* $Id$ | ||
* | ||
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS | ||
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT | ||
* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR | ||
* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT | ||
* OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, | ||
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT | ||
* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, | ||
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY | ||
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT | ||
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE | ||
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | ||
* | ||
* This software consists of voluntary contributions made by many individuals | ||
* and is licensed under the LGPL. For more information, see | ||
* <http://www.doctrine-project.org>. | ||
*/ | ||
|
||
/** | ||
* Doctrine_Migration_TestCase | ||
* | ||
* @package Doctrine | ||
* @author Konsta Vesterinen <[email protected]> | ||
* @license http://www.opensource.org/licenses/lgpl-license.php LGPL | ||
* @category Object Relational Mapping | ||
* @link www.doctrine-project.org | ||
* @since 1.0 | ||
* @version $Revision$ | ||
*/ | ||
class Doctrine_MigrationMysql_TestCase extends Doctrine_UnitTestCase | ||
{ | ||
public function setUp() | ||
{ | ||
parent::setUp(); | ||
$dsn = getenv('MYSQL_TEST_DSN') ?? ''; | ||
|
||
$this->connection = $this->openAdditionalPdoConnection($dsn); | ||
$this->connection->setOption('dsn', $dsn); | ||
$this->connection->dropDatabase(); | ||
$this->connection->createDatabase(); | ||
} | ||
|
||
public function testAfterSuccessfullMigrationItWillSetMigratedVersionAsCurrentVersionInMysqlDB() | ||
{ | ||
$migration = new Doctrine_Migration(__DIR__.'/migration_classes', $this->connection); | ||
$this->assertFalse($migration->hasMigrated()); | ||
$migration->setCurrentVersion(0); | ||
$this->assertFalse($this->connection->import->tableExists('migration_phonenumber')); | ||
$this->assertFalse($this->connection->import->tableExists('migration_user')); | ||
$this->assertFalse($this->connection->import->tableExists('migration_profile')); | ||
|
||
$migration->migrate(3); | ||
$this->assertTrue($migration->hasMigrated()); | ||
$this->assertEqual($migration->getCurrentVersion(), 3); | ||
$this->assertTrue($this->connection->import->tableExists('migration_phonenumber')); | ||
$this->assertTrue($this->connection->import->tableExists('migration_user')); | ||
$this->assertTrue($this->connection->import->tableExists('migration_profile')); | ||
|
||
$migration->migrate(4); | ||
$this->assertEqual($migration->getCurrentVersion(), 4); | ||
$this->assertTrue($this->connection->import->tableExists('migration_phonenumber')); | ||
$this->assertTrue($this->connection->import->tableExists('migration_user')); | ||
$this->assertFalse($this->connection->import->tableExists('migration_profile')); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters