-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the export command to use a PHP8-safe PDO transaction commit path #131
base: master
Are you sure you want to change the base?
Update the export command to use a PHP8-safe PDO transaction commit path #131
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How can you prove that this modification fix the issue?
How can we describe the behaviour that make current code on master branch throw the error?
I'm not familiar enough with the internals of this package to build the test, but this behavior occurs when:
I began writing a test but couldn't get the test suite to run on my machine, and wasn't sure how to mock the change in PDO behavior from 7.x to 8.0 I do see the task behavior is fixed on a build pointing at my forks branch, help figuring out how to build the test for it would be appreciated |
@mcgrogan91 Yes, the patch you provide works. 💯 Sadly, the current CI does not support its execution as missing a MySQL server. How I executed the test suite?
|
I'm glad to hear your testing of it worked. What's the next step to get this moving? Right now we have our application pointing at my fork but i'd love to get us back onto the main repository before moving forward with a production deploy |
Any update on this? Any chance of merging this PR? |
3318b63
to
d420b2a
Compare
* $Id$ | ||
* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* $Id$ | |
* |
|
||
$connection->commit(); | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
} | |
} | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a couple of minor suggestions.
WDYT?
Addresses an issue reported in #130