forked from doctrine/doctrine1
-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Hydrator): Array hydration having always primary key and selected relations #135
Open
alquerci
wants to merge
37
commits into
FriendsOfSymfony1:master
Choose a base branch
from
alquerci:fix-add-failing-test-when-aliasing-a-column-of-a-joined-relation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alquerci
force-pushed
the
fix-add-failing-test-when-aliasing-a-column-of-a-joined-relation
branch
from
April 15, 2024 18:31
0e1b2b4
to
5596999
Compare
After revert #109
|
alquerci
force-pushed
the
fix-add-failing-test-when-aliasing-a-column-of-a-joined-relation
branch
from
April 15, 2024 18:41
5596999
to
6a0fe33
Compare
alquerci
changed the title
[WIP] fix: add failing test when aliasing a column of a joined relation
[WIP] fix(Hydrator): Array hydration having always primary key and selected relations
Apr 15, 2024
alquerci
changed the title
[WIP] fix(Hydrator): Array hydration having always primary key and selected relations
fix(Hydrator): Array hydration having always primary key and selected relations
Apr 16, 2024
alquerci
force-pushed
the
fix-add-failing-test-when-aliasing-a-column-of-a-joined-relation
branch
from
April 16, 2024 06:43
0d7180d
to
c61998f
Compare
On previous behaviour the array hydration relation have the identifier, even if not explicitly given on DQL, 8aef340 SELECT
rootAlias.id,
relationAlias.field
FROM RootRecord rootAlias
INNER JOIN RelationRecord relationAlias After array hydration - id: 'some-root-record-id'
RelationName:
id: 'some-relation-record-id'
field: 'some_relation_field_value' So there is another rule not frozen by the actual test suite. On Array hydration identifier of the relation is always present even when not explicitly on DQL select. |
alquerci
force-pushed
the
fix-add-failing-test-when-aliasing-a-column-of-a-joined-relation
branch
from
April 16, 2024 20:07
225e175
to
ca20e82
Compare
alquerci
changed the title
fix(Hydrator): Array hydration having always primary key and selected relations
[WIP] fix(Hydrator): Array hydration having always primary key and selected relations
Apr 16, 2024
…om aliases" This reverts commit 4dd7c86d723946f547bdb19976a9a1b9b5dc66ff.
…om aliases" This reverts commit 0ec3738.
alquerci
force-pushed
the
fix-add-failing-test-when-aliasing-a-column-of-a-joined-relation
branch
from
April 17, 2024 21:17
01fd136
to
3777119
Compare
alquerci
changed the title
[WIP] fix(Hydrator): Array hydration having always primary key and selected relations
fix(Hydrator): Array hydration having always primary key and selected relations
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #134