[storage] improvement: use null coalescing operator

FriendsOfSymfony1 · Apr 9, 2024 · 1c5e9e7 · 1c5e9e7
1 parent c90af2c
commit 1c5e9e7
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 21 deletions.
diff --git a/lib/storage/sfCacheSessionStorage.class.php b/lib/storage/sfCacheSessionStorage.class.php
@@ -176,13 +176,7 @@ public function write($key, $data)
      */
     public function read($key)
     {
-        $retval = null;
-
-        if (isset($this->data[$key])) {
-            $retval = &$this->data[$key];
-        }
-
-        return $retval;
+        return $this->data[$key] ?? null;
     }
 
     /**

diff --git a/lib/storage/sfSessionStorage.class.php b/lib/storage/sfSessionStorage.class.php
@@ -105,13 +105,7 @@ public function initialize($options = null)
      */
     public function read($key)
     {
-        $retval = null;
-
-        if (isset($_SESSION[$key])) {
-            $retval = $_SESSION[$key];
-        }
-
-        return $retval;
+        return $_SESSION[$key] ?? null;
     }
 
     /**

diff --git a/lib/storage/sfSessionTestStorage.class.php b/lib/storage/sfSessionTestStorage.class.php
@@ -74,13 +74,7 @@ public function getSessionId()
      */
     public function read($key)
     {
-        $retval = null;
-
-        if (isset($this->sessionData[$key])) {
-            $retval = $this->sessionData[$key];
-        }
-
-        return $retval;
+        return $this->sessionData[$key] ?? null;
     }
 
     /**