[test] add phpunit tests

.github/workflows/continuous-integration.yml

@@ -58,4 +58,4 @@ jobs:
         run: php data/bin/check_configuration.php
 
       - name: Run Tests
-        run: php data/bin/symfony symfony:test --trace
+        run: php vendor/bin/phpunit

lib/autoload/sfCoreAutoload.class.php

@@ -301,6 +301,11 @@ class sfCoreAutoload
         'sftesterresponse' => 'test/sfTesterResponse.class.php',
         'sftesteruser' => 'test/sfTesterUser.class.php',
         'sftesterviewcache' => 'test/sfTesterViewCache.class.php',
+        'symfony1applicationtestcase' => 'test/Symfony1ApplicationTestCase.php',
+        'symfony1projecttestcase' => 'test/Symfony1ProjectTestCase.php',
+        'testcasedrivenapplicationconfiguration' => 'test/TestCaseDrivenApplicationConfiguration.php',
+        'testcasedrivenconfigurationinterface' => 'test/TestCaseDrivenConfigurationInterface.php',
+        'testcasedrivenprojectconfiguration' => 'test/TestCaseDrivenProjectConfiguration.php',
         'sfbasicsecurityuser' => 'user/sfBasicSecurityUser.class.php',
         'sfsecurityuser' => 'user/sfSecurityUser.class.php',
         'sfuser' => 'user/sfUser.class.php',

lib/cache/sfAPCCache.class.php

@@ -69,6 +69,7 @@ public function has($key)
      * @see sfCache
      *
      * @param mixed|null $lifetime
+     *
      * @return bool|array
      */
     public function set($key, $data, $lifetime = null)

lib/cache/sfFileCache.class.php

@@ -65,7 +65,7 @@ public function get($key, $default = null)
 
         $rawData = $data[self::READ_DATA];
 
-        if ($rawData === 'FaLSe') {
+        if ('FaLSe' === $rawData) {
             $rawData = false;
         }
 
@@ -93,7 +93,7 @@ public function set($key, $data, $lifetime = null)
             $this->clean(sfCache::OLD);
         }
 
-        if ($data === false) {
+        if (false === $data) {
             $data = 'FaLSe';
         }
 

lib/cache/sfSQLiteCache.class.php

@@ -72,7 +72,7 @@ public function get($key, $default = null)
             $data = $this->dbh->singleQuery(sprintf("SELECT data FROM cache WHERE key = '%s' AND timeout > %d", sqlite_escape_string($key), time()));
         }
 
-        if ($data === 'FaLSe') {
+        if ('FaLSe' === $data) {
             $data = false;
         }
 
@@ -102,7 +102,7 @@ public function set($key, $data, $lifetime = null)
             $this->clean(sfCache::OLD);
         }
 
-        if ($data === false) {
+        if (false === $data) {
             $data = 'FaLSe';
         }
 

lib/test/Symfony1ApplicationTestCase.php

@@ -0,0 +1,55 @@
+<?php
+
+/*
+ * This file is part of the symfony package.
+ * (c) Fabien Potencier <[email protected]>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+use PHPUnit\Framework\TestCase;
+
+class Symfony1ApplicationTestCase extends TestCase
+{
+    public function resetSfConfig()
+    {
+        sfConfig::set('sf_symfony_lib_dir', realpath(__DIR__.'/../lib'));
+        sfConfig::set('sf_test_cache_dir', sys_get_temp_dir().'/sf_test_project');
+    }
+
+    public function getEnvironment()
+    {
+        return 'test';
+    }
+
+    public function getDebug()
+    {
+        return true;
+    }
+
+    public function getEventDispatcher()
+    {
+        return null;
+    }
+
+    public function getRootDir()
+    {
+        return null;
+    }
+
+    public function projectSetup(sfApplicationConfiguration $applicationConfiguration)
+    {
+    }
+
+    public function getApplicationConfiguration()
+    {
+        return new TestCaseDrivenApplicationConfiguration(
+            $this,
+            $this->getEnvironment(),
+            $this->getDebug(),
+            $this->getRootDir(),
+            $this->getEventDispatcher()
+        );
+    }
+}

lib/test/Symfony1ProjectTestCase.php

@@ -0,0 +1,39 @@
+<?php
+
+/*
+ * This file is part of the symfony package.
+ * (c) Fabien Potencier <[email protected]>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+use PHPUnit\Framework\TestCase;
+
+class Symfony1ProjectTestCase extends TestCase
+{
+    public function resetSfConfig()
+    {
+        sfConfig::set('sf_symfony_lib_dir', realpath(__DIR__.'/../lib'));
+        sfConfig::set('sf_test_cache_dir', sys_get_temp_dir().'/sf_test_project');
+    }
+
+    public function projectSetup(sfProjectConfiguration $configuration)
+    {
+    }
+
+    public function getEventDispatcher()
+    {
+        return null;
+    }
+
+    public function getRootDir()
+    {
+        return null;
+    }
+
+    public function getProjectConfiguration()
+    {
+        return new TestCaseDrivenProjectConfiguration($this, $this->getRootDir(), $this->getEventDispatcher());
+    }
+}

lib/test/TestCaseDrivenApplicationConfiguration.php

@@ -0,0 +1,37 @@
+<?php
+
+/*
+ * This file is part of the symfony package.
+ * (c) Fabien Potencier <[email protected]>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+class TestCaseDrivenApplicationConfiguration extends sfApplicationConfiguration implements TestCaseDrivenConfigurationInterface
+{
+    protected $testCase;
+
+    public function __construct($testCase, $environment, $debug, $rootDir = null, sfEventDispatcher $dispatcher = null)
+    {
+        $this->testCase = $testCase;
+        parent::__construct($environment, $debug, $rootDir, $dispatcher);
+    }
+
+    /**
+     * @return mixed
+     */
+    public function getTestCase()
+    {
+        return $this->testCase;
+    }
+
+    public function getI18NGlobalDirs()
+    {
+        if (method_exists($this->testCase, 'getI18NGlobalDirs')) {
+            return $this->testCase->getI18NGlobalDirs();
+        }
+
+        return parent::getI18NGlobalDirs();
+    }
+}

tests/fixtures/ProjectConfiguration5.php → lib/test/TestCaseDrivenConfigurationInterface.php

@@ -8,6 +8,7 @@
  * file that was distributed with this source code.
  */
 
-class ProjectConfiguration extends sfProjectConfiguration
+interface TestCaseDrivenConfigurationInterface
 {
-}
+    public function getTestCase();
+}

lib/test/TestCaseDrivenProjectConfiguration.php

@@ -0,0 +1,29 @@
+<?php
+
+/*
+ * This file is part of the symfony package.
+ * (c) Fabien Potencier <[email protected]>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+class TestCaseDrivenProjectConfiguration extends ProjectConfiguration implements TestCaseDrivenConfigurationInterface
+{
+    protected $testCase;
+
+    public function __construct($testCase, $rootDir = null, sfEventDispatcher $dispatcher = null)
+    {
+        $this->testCase = $testCase;
+
+        parent::__construct($rootDir, $dispatcher);
+    }
+
+    /**
+     * @return mixed
+     */
+    public function getTestCase()
+    {
+        return $this->testCase;
+    }
+}

lib/validator/sfValidatorDate.class.php

@@ -139,7 +139,7 @@ protected function doClean($value)
 
         $format = $this->getOption('with_time') ? $this->getOption('datetime_output') : $this->getOption('date_output');
 
-        if ($format === 'U') {
+        if ('U' === $format) {
             return isset($date) ? (int) $date->format($format) : (int) date($format, $cleanTime);
         }
 

lib/validator/sfValidatorError.class.php

@@ -108,7 +108,7 @@ public function getArguments($raw = false)
                 continue;
             }
 
-            $arguments["%{$key}%"] = $value !== null ? htmlspecialchars($value, ENT_QUOTES, sfValidatorBase::getCharset()) : '';
+            $arguments["%{$key}%"] = null !== $value ? htmlspecialchars($value, ENT_QUOTES, sfValidatorBase::getCharset()) : '';
         }
 
         return $arguments;

lib/validator/sfValidatorString.class.php

@@ -51,7 +51,7 @@ protected function configure($options = array(), $messages = array())
      */
     protected function doClean($value)
     {
-        if ($value === null) {
+        if (null === $value) {
             return $value;
         }
 

lib/validator/sfValidatorTime.class.php

@@ -74,7 +74,7 @@ protected function doClean($value)
         $formattedClean = date($this->getOption('time_output'), $clean);
 
         // don't change integer type
-        if ($this->getOption('time_output') === 'U') {
+        if ('U' === $this->getOption('time_output')) {
             settype($formattedClean, 'integer');
         }
 

tests/PhpUnitSfTestHelperTrait.php

@@ -10,24 +10,21 @@
 
 trait PhpUnitSfTestHelperTrait
 {
-    public function diag($message): void
-    {
-
-    }
-
-    public function arrays_are_equal($actual, $expected, string $message = ''): void
-    {
-        sort($actual);
-        sort($expected);
-
-        $this->is($expected, $actual, $message);
-    }
+    public function diag($message): void {}
 
+    /**
+     * @see self::assertSame
+     * @deprecated
+     */
     public function is($actual, $expected, string $message = ''): void
     {
         $this->assertSame($expected, $actual, $message);
     }
 
+    /**
+     * @see self::assertNotSame
+     * @deprecated
+     */
     public function isnt($actual, $expected, string $message = ''): void
     {
         $this->assertNotSame($expected, $actual, $message);
@@ -50,12 +47,12 @@ public function ok($actual, string $message = ''): void
 
     public function isa_ok($actual, $expected, string $message = ''): void
     {
-        if ($expected === 'array') {
+        if ('array' === $expected) {
             $this->assertIsArray($actual, $message);
         } elseif (str_starts_with($expected, 'sf')) {
             $this->assertInstanceOf($expected, $actual, $message);
         } else {
-            throw new \RuntimeException('unhandled type: '. $expected);
+            throw new \RuntimeException('unhandled type: '.$expected);
         }
     }
 

tests/action/sfComponentTest.php

@@ -24,10 +24,10 @@ class sfComponentTest extends sfEventDispatcherTestCase
 
     public function setUp(): void
     {
-        $this->context = sfContext::getInstance([
+        $this->context = sfContext::getInstance(array(
             'routing' => 'sfNoRouting',
             'request' => 'sfWebRequest',
-        ]);
+        ));
 
         $this->testObject = new myComponent($this->context, 'module', 'action');
         $this->dispatcher = $this->context->getEventDispatcher();
@@ -70,8 +70,8 @@ public function testSetter()
     {
         $component = new myComponent($this->context, 'module', 'action');
 
-        $component->foo = [];
+        $component->foo = array();
         $component->foo[] = 'bar';
-        $this->assertSame(['bar'], $component->foo, '__set() populates component variables');
+        $this->assertSame(array('bar'), $component->foo, '__set() populates component variables');
     }
 }

tests/bootstrap.php

@@ -27,6 +27,8 @@
 require_once $libDir.'/util/sfToolkit.class.php';
 sfConfig::set('sf_test_cache_dir', sys_get_temp_dir().'/sf_test_project');
 
+require_once __DIR__.'/fixtures/symfony/config/ProjectConfiguration.class.php';
+
 // remove all test cache
 sf_unit_test_shutdown();
 
@@ -47,7 +49,7 @@ function sf_unit_test_shutdown()
     $sessions = glob(sys_get_temp_dir().'/sessions*');
     $tmp_files = glob(sys_get_temp_dir().'/sf*');
 
-    $files = array_merge(empty($sessions) ? [] : $sessions, empty($tmp_files) ? [] : $tmp_files);
+    $files = array_merge(empty($sessions) ? array() : $sessions, empty($tmp_files) ? array() : $tmp_files);
     foreach ($files as $file) {
         if (is_dir($file)) {
             sfToolkit::clearDirectory($file);
@@ -61,5 +63,5 @@ function sf_unit_test_shutdown()
 // Helper for cross platform testcases that validate output
 function fix_linebreaks($content)
 {
-    return str_replace(["\r\n", "\n", "\r"], "\n", $content);
+    return str_replace(array("\r\n", "\n", "\r"), "\n", $content);
 }