php8.3 in the party #294
Merged
php8.3 in the party #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorhu
force-pushed
the
feature/php83
branch
from
db588f9
to
7130e3b
Compare
connorhu
force-pushed
the
feature/php83
branch
from
b1ed6d7
to
f7972ef
Compare
|
I am not sure about what cause the single_space_around_construct warnings. This rule introduced at v3.16.0. This is not php version related problem. |
|
It could be that the last time php-CS-Fixer was run, it was in a previous version, thus that check not "default". Let's fix it in this PR, wdyt? |
|
What exactly is php-cs-fixer criticizing here? To be honest, I don't see any issues in line #1 of the mentioned files? |
|
|
Thanks, in the end it's not the opening php tag marked in line one. For me, it would be ok to fix it in this pr. Wdyt, @connorhu? |
|
and it's done. |
thirsch
approved these changes
Dec 16, 2023
alquerci
approved these changes
Dec 16, 2023
thePanz
approved these changes
Dec 18, 2023
|
Thanks @connorhu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If php8.3 is already released, let's do a test with this version.