-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[QA] added phpstan dist config #312
base: master
Are you sure you want to change the base?
Conversation
46c3964
to
2711edd
Compare
@connorhu I added something like this to exclude files not relevant for phpstan
|
ffb5e24
to
a347c93
Compare
@thePanz Thank you! Updated the config. Should we do the same as doctrine1? (php7.4 and php8.3 simultan tests) |
{ | ||
} | ||
|
||
include 'PEAR/REST/10.php'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙈 why do we need PEAR?! 🙈
Should we completely drop it? @thirsch IIRC you mentioned something like this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plugin uses this. i would drop it too as you can see in my plugin loading improvement issue #342 . if only because the default symfony channels don't work. refer to propel discussion
composer.json
Outdated
@@ -8,7 +8,8 @@ | |||
"friendsofsymfony1/swiftmailer": "^5.4.13 || ^6.2.5" | |||
}, | |||
"require-dev": { | |||
"psr/log": "*" | |||
"psr/log": "*", | |||
"friendsofsymfony1/doctrine1": "*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we define the min-versions here?
should swiftmailer be added too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Swiftmailer is in required section.
What is the min version should be?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Swiftmailer is in required section
🙈 true 😅
Does it mean that we can remove the GIT submodules then?
What is the min version should be?
I would pick the latest tagged one IMO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The expert on submodule removal is @thirsch . Paging dr @thirsch
#302 (comment)
25bb848
to
7cc334d
Compare
No description provided.