Fix mse for least squares PCE (#128)

FriesischScott · Sep 5, 2023 · 8429fcb · 8429fcb · FriesischScott · Sep 5, 2023
1 parent b3130d5
commit 8429fcb
Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/Project.toml b/Project.toml
@@ -1,7 +1,7 @@
 name = "UncertaintyQuantification"
 uuid = "7183a548-a887-11e9-15ce-a56ab60bad7a"
 authors = ["Jasper Behrensdorf <[email protected]>", "Ander Gray <[email protected]>"]
-version = "0.7.1"
+version = "0.7.2"
 
 [deps]
 Bootstrap = "e28b5b4c-05e8-5b66-bc03-6f0c0a0a06e0"

diff --git a/src/models/pce/polynomialchaosexpansion.jl b/src/models/pce/polynomialchaosexpansion.jl
@@ -31,7 +31,7 @@ function polynomialchaos(
     y = A \ samples[:, output]
 
     ϵ = samples[:, output] - A * y
-    mse = dot(ϵ, ϵ)
+    mse = mean(ϵ .^ 2)
 
     to_physical_space!(random_inputs, samples)
 

diff --git a/test/models/pce/polynomialchaosexpansion.jl b/test/models/pce/polynomialchaosexpansion.jl
@@ -16,10 +16,15 @@
 
     @testset "LeastSquares" begin
         ls = LeastSquares(SobolSampling(1000))
-        pce, _, _ = polynomialchaos(x, model, Ψ, :y, ls)
+        pce, samples, mse = polynomialchaos(x, model, Ψ, :y, ls)
+
+        new_samples = samples[:, Not(:y1, :y)]
+        evaluate!(pce, new_samples)
+        ϵ = mean((new_samples.y .- samples.y) .^ 2)
 
         @test mean(pce) ≈ -1.5 rtol = 1e-10
         @test var(pce) ≈ 0.5 rtol = 1e-10
+        @test mse ≈ ϵ atol = eps()
     end
 
     @testset "GaussQuadrature" begin