Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Android status bar to match the background color #42

Merged
merged 2 commits into from
Oct 11, 2016

Conversation

SandroMachado
Copy link
Contributor

This PR adds support to update the status bar to match the slide background color in Android. This is only available for basic usage.

sample-android

  render() {
    const pageArray = [{
      title: 'Page 1',
      description: 'Description 1',
      img: 'https://goo.gl/Bnc3XP',
      imgStyle: {
        height: 80 * 2.5,
        width: 109 * 2.5,
      },
      backgroundColor: '#fa931d',
      fontColor: '#fff',
      level: 10,
    }, {
      title: 'Page 2',
      description: 'Description 2',
      img: 'https://goo.gl/Bnc3XP',
      imgStyle: {
        height: 93 * 2.5,
        width: 103 * 2.5,
      },
      backgroundColor: '#a4b602',
      fontColor: '#fff',
      level: 10,
    }];
    return (
      <AppIntro
        onNextBtnClick={this.nextBtnHandle}
        onDoneBtnClick={this.doneBtnHandle}
        onSkipBtnClick={this.onSkipBtnHandle}
        onSlideChange={this.onSlideChangeHandle}
        pageArray={pageArray}
      />
    );
  }

@FuYaoDe
Copy link
Owner

FuYaoDe commented Oct 11, 2016

Thanks!!
But I found your background color is written dead, and in pageArray you can custom backgroundColor, maybe this part can be dynamic.
Then the Example section thank you for helping me upgrade, but the scope of change too much, I can't verify whether it's a PR issue or React Native, please don't move the Example section, that's my only job 😄

@FuYaoDe
Copy link
Owner

FuYaoDe commented Oct 11, 2016

Oh sorry.... I saw it this.props.pageArray[0].backgroundColor

@SandroMachado
Copy link
Contributor Author

Thanks for the reply.

The changes in the example section are to update the project to the latest react native version. If you prefer I can move this to another PR. It is easy for the community to test the sample app in the latest version. WDYT?

@FuYaoDe
Copy link
Owner

FuYaoDe commented Oct 11, 2016

OK, open a new one PR, I will review too thanks!!

@SandroMachado
Copy link
Contributor Author

@FuYaoDe thanks! I created #43 to update the React Native version for the demo app.

@FuYaoDe FuYaoDe merged commit 3c6b6aa into FuYaoDe:master Oct 11, 2016
@FuYaoDe
Copy link
Owner

FuYaoDe commented Oct 11, 2016

Awesome !! Looks more harmonious
If I have time I'll add it fade animation to change color
Hopefully there will be no performance issues...

@SandroMachado
Copy link
Contributor Author

@FuYaoDe Thanks :)

@SandroMachado
Copy link
Contributor Author

@FuYaoDe Do you have plans for making a release?

@FuYaoDe
Copy link
Owner

FuYaoDe commented Oct 11, 2016

In fact, this is my first project so many stars, I have not tried release let me look at the study 😅

@SandroMachado
Copy link
Contributor Author

SandroMachado commented Oct 11, 2016

Great! Please let me know if you need any help. Making releases will help to control the code and breaking changes.

For generating the changelog, If you want to make a changelog, I will suggest this tool: https://github.com/skywinder/github-changelog-generator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants