Fixing problems with online feeds with 100+ packages + tests #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem which I had was with nuget.org on which FloatingFeed.cs cannot find package by name.
It was caused by wrongly method with downloading all packages from feed. The previous way was trying to use following query: /Packages()?$filter=IsLatestVersion&$orderby=DownloadCount%20desc,Id&$skip={0}&$top=100.
But nuget.org returns only 40 packages even if top=100 is specified.
I added test (named load_all_packages_from_feed_with_100plus_packages) which shows this problem.
Moreover I decided to optimize way of getting latest in findLatest method. Previously it was done by downloading all packages from feed and then query it for selected packages. Instead I deiced to query for specified packages, which doesn't need to download full feed.