Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Floating dependency should skip version check #276

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ptrstpp950
Copy link
Contributor

There is a problem with following configuration:

  1. Nuget feed is marked as fixed
  2. Dependency is marked as float but has specified version in file (e.g.: nuget 'Microsoft.Net.Http', version: '2.0.20710.0', mode: 'Float' in ripple file)

The above configuration works differently comparing to: nuget 'Microsoft.Net.Http', mode: 'Float'

In my opinion these two are exactly, because in Float mode version doesn't change anything.

@kYann
Copy link

kYann commented Apr 17, 2014

I'm new to ripple but this doesn't seems to be the same.

Float doesn't mean latest, float as version boundaries as specified by DefaultFloatConstraint.

@kYann
Copy link

kYann commented Apr 17, 2014

Also you have created your branch floatingDependencyShouldSkipVersionCheck on branch feed100PlusProblems, meaning that the merge of this branch (floatingDependencyShouldSkipVersionCheck) would also merge floatingDependencyShouldSkipVersionCheck :/

@jmarnold
Copy link
Contributor

I think @kYann is right. @ptrstpp950 I wrote the version semantics to work in Float mode as "minimum required version".

@ptrstpp950
Copy link
Contributor Author

@jmarnold The problems is that I have to upload this "minimum required version" to feed, because when it doesn't exist on feed ripple just fail with error.

@kYann You are right about feed100PlusProblems branch I will fix it.

@ptrstpp950
Copy link
Contributor Author

Maybe one more thing: if @kYann is right float with specified ONE version (not range) should work as fixed, because only ONE version fulfill DefaultFloatConstraint

@jmarnold
Copy link
Contributor

My vision for the "real" fix for this was to introduce a version range
syntax like gems (e.g., "~> 3.0"). I have a branch out there with the
parser and data structure implemented. I just never tweaked the nuget
queries to respect it.

On Saturday, April 19, 2014, Piotr Stapp [email protected] wrote:

Maybe one more thing @kYann https://github.com/kYann is right float
with specified ONE version (not range) should work as fixed, because only
ONE version fulfill DefaultFloatConstraint


Reply to this email directly or view it on GitHubhttps://github.com//pull/276#issuecomment-40865929
.

@ptrstpp950
Copy link
Contributor Author

Why you would like to introduce new syntax? The nuget versions syntax coverts all set of versions. Your example ("~> 3.0") can be written as: (3.0,) or [3.0,) (depednds if ~> is equal to > or =>) according to: https://docs.nuget.org/docs/reference/versioning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants