Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Including libraries(jQuery, Backbone, Underscore) to app #61

Merged
merged 2 commits into from
Dec 15, 2016
Merged

Including libraries(jQuery, Backbone, Underscore) to app #61

merged 2 commits into from
Dec 15, 2016

Conversation

logeshpaul
Copy link
Member

Why?

  • The user should be able to include commonly used libraries(eg. jQuery) while creating the app

What's Done?

  • Included most commonly used libraries(jQuery, Backbone, Underscore) as options
  • Excluded modernizer and it's not widely used. Also, for the reason now modenizer doesn't ship as a single file which causes an issue (Gulp cant find Modernizr Error on Fullpack #60)

houndci-bot
houndci-bot reviewed Dec 11, 2016
View reviewed changes
app/index.js
smacssGenerator.prototype.askAppFeatures = function askAppFeatures() {
if(this.appType === 'typeFullPackWebApp' || this.appType === 'typeAngularApp' || this.appType === 'typeAdminWebApp') {
smacssGenerator.prototype.askAppLibraries = function askAppLibraries() {
if(this.appType === 'typeFullPackWebApp' || this.appType === 'typeAdminWebApp') {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is too long.

DarshanKumar89
DarshanKumar89 approved these changes Dec 14, 2016
View reviewed changes
Copy link

@DarshanKumar89 DarshanKumar89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its good to merge

@logeshpaul logeshpaul merged commit 02ae69e into master Dec 15, 2016
@logeshpaul logeshpaul deleted the lp-include-libraries branch December 15, 2016 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houndci-bot houndci-bot houndci-bot left review comments

@DarshanKumar89 DarshanKumar89 DarshanKumar89 approved these changes

@gokulkrishh gokulkrishh Awaiting requested review from gokulkrishh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@logeshpaul @DarshanKumar89 @houndci-bot