fix: nightly fuels-ts docs API changes breaking the CI #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nedsalk
commented
Jan 29, 2025
| @@ -35,6 +35,7 @@ export async function updateSubmodules(newDefaultVersions, newNightlyVersions) { | |||
| 'docs/nightly/fuel-specs', | |||
| 'docs/nightly/fuel-graphql-docs', | |||
| 'docs/nightly/migrations-and-disclosures', | |||
| 'docs/nightly/fuels-ts', | |||
There was a problem hiding this comment.
This addition ensures that every call to the update-nightly workflow updates the nightly fuels-ts version. I only added fuels-ts and not the other repositories that have nightly versions because:
- I want to keep the focus on the API docs issue which is
fuels-ts-specific, fuels-tsis the only repository in theversions.jsonfile that calls theupdate-nightlyworkflow (reference).
Important
This will still require manual merging of the nightly docs PR - nothing changed about that.
Handling of the other nightly versions more appropriately would be done via
nedsalk
changed the title
DOCS_API_URL for fuels-ts API docs
nedsalk
requested review from
calldelegation,
petertonysmith94,
arboleya,
Torres-ssf and
danielbate
4 tasks
petertonysmith94
approved these changes
Feb 6, 2025
arboleya
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to FuelLabs/fuels-ts#3572 and to be merged before
so that the PR in the TS SDK can be verified to work. I already tested it locally by checking out that PR in
docs/fuels-tsanddocs/nightly/fuels-ts.