fault_proving(global_roots): Initial test suite for merklized storage updates #2598
+252
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netrome
changed the title
netrome
force-pushed
the
2552-feature-flag-for-global-state-roots-+-first-onchain-table-implementation
branch
from
83f9cc9 to
d83cd6f
Compare
netrome
force-pushed
the
2582-fault_provingglobal_roots-initial-test-suite-for-storage-updates
branch
from
b0be2e5 to
c45ab47
Compare
netrome
force-pushed
the
2552-feature-flag-for-global-state-roots-+-first-onchain-table-implementation
branch
2 times, most recently
from
d2cdb38 to
81b6582
Compare
Base automatically changed from
2552-feature-flag-for-global-state-roots-+-first-onchain-table-implementation
to
master
January 28, 2025 16:56
netrome
force-pushed
the
2582-fault_provingglobal_roots-initial-test-suite-for-storage-updates
branch
from
c45ab47 to
ce34251
Compare
12 tasks
netrome
requested review from
xgreenx,
Dentosal and
MitchTurner
as code owners
netrome
force-pushed
the
2582-fault_provingglobal_roots-initial-test-suite-for-storage-updates
branch
from
06c9de2 to
928ac03
Compare
netrome
force-pushed
the
2582-fault_provingglobal_roots-initial-test-suite-for-storage-updates
branch
from
928ac03 to
b9bdd5e
Compare
MitchTurner
reviewed
Jan 29, 2025
| &mut self, | ||
| self, |
There was a problem hiding this comment.
This is unintuitive to me. I'd expect something that updates, to be mut, and definitely not consume the struct.
What prompted this change?
| } | ||
|
|
||
| #[test] | ||
| fn process_input__should_remove_coin() { |
There was a problem hiding this comment.
As someone with little context here, it's not obvious to me what the difference between process_output__should_insert_coin and process_input__should_remove_coin are. It would be nice to explain the conditions for coin being added or removed in the test name so I know what I'm looking for.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2582
Description
This PR adds an initial test suite for the merkelized storage update functionality. These tests ensure that the insertion and deletion behavior for coins (except message coins, to be added in #2597) and contract UTXOs is correct.