Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gas_price_service): minor refactors to make the code more readable #2636

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

rymnc
Copy link
Member

@rymnc rymnc commented Jan 26, 2025

Linked Issues/PRs

  • none

Description

AI generated pr desc:
This pull request includes various changes to improve code readability, simplify logic, and ensure consistency across the gas_price_service module. The most important changes include refactoring trait bounds, updating method calls, and improving error handling.

Refactoring trait bounds:

Updating method calls:

Improving error handling:

Consistency improvements:

These changes collectively enhance the maintainability and performance of the gas_price_service module.

Checklist

  • Breaking changes are clearly marked as such in the PR description and changelog
  • New behavior is reflected in tests
  • The specification matches the implemented behavior (link update PR if changes are needed)

Before requesting review

  • I have reviewed the code myself
  • I have created follow-up issues caused by this PR and linked them here

@rymnc rymnc self-assigned this Jan 26, 2025
@rymnc rymnc added the no changelog Skip the CI check of the changelog modification label Jan 26, 2025
Copy link
Contributor

@acerone85 acerone85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks :)

@rymnc rymnc marked this pull request as ready for review January 27, 2025 15:02
@rymnc rymnc requested a review from a team January 27, 2025 15:03
@rymnc rymnc merged commit 59e8271 into master Jan 28, 2025
32 checks passed
@rymnc rymnc deleted the fix/minor-refactors-gas-price-service branch January 28, 2025 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Skip the CI check of the changelog modification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants