Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fixed interplay with resource cache tests #3601

Merged
merged 11 commits into from
Jan 21, 2025
Merged

chore: fixed interplay with resource cache tests #3601

merged 11 commits into from
Jan 21, 2025

Conversation

petertonysmith94
Copy link
Contributor

@petertonysmith94 petertonysmith94 commented Jan 20, 2025 •
edited by fuel-service-user
Loading

Summary

  • Made the cache resource tests sequential, and clear cache after every test to ensure no interplay.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@vercel Vercel
Copy link

vercel bot commented Jan 20, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2025 9:17am
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2025 9:17am
ts-docs-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2025 9:17am

@github-actions github-actions bot added the chore Issue is a chore label Jan 20, 2025
@petertonysmith94 petertonysmith94 changed the title chore: investigate flakey test chore: fixed interplay with resource cache tests Jan 20, 2025
@petertonysmith94 petertonysmith94 self-assigned this Jan 20, 2025
@petertonysmith94 petertonysmith94 marked this pull request as ready for review January 20, 2025 18:17
@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
77.04%(+0%) 70.64%(+0%) 75.1%(+0%) 77.04%(+0%)
Changed Files:

Coverage values did not change👌.

@petertonysmith94 petertonysmith94 merged commit 79ffb82 into master Jan 21, 2025
24 checks passed
@petertonysmith94 petertonysmith94 deleted the ps/chore/investigate-flakey-test branch January 21, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nedsalk nedsalk nedsalk approved these changes

@arboleya arboleya arboleya approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@danielbate danielbate Awaiting requested review from danielbate danielbate is a code owner

@Torres-ssf Torres-ssf Awaiting requested review from Torres-ssf Torres-ssf is a code owner

Assignees

@petertonysmith94 petertonysmith94

Labels
chore Issue is a chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate flakiness with Resource cache test
4 participants
@petertonysmith94 @arboleya @nedsalk @Torres-ssf