fix: prettier config trailing comma and vscode (#942)

.changeset/new-dolphins-study.md

@@ -0,0 +1,2 @@
+---
+---

.prettierrc.js

@@ -0,0 +1,9 @@
+const fuelPrettierConfig = require('@fuels/prettier-config');
+
+/** @type {import("prettier").Config} */
+module.exports = {
+  ...fuelPrettierConfig,
+  // trailingComma always adds comma on the end of functions params, that can cause
+  // issues, when a second param can't be undefined.
+  trailingComma: 'es5',
+};

.vscode/settings.json

@@ -1,6 +1,6 @@
 {
   "editor.defaultFormatter": "esbenp.prettier-vscode",
-  "prettier.prettierPath": "./node_modules/prettier",
+  "prettier.prettierPath": "./node_modules/prettier/index.cjs",
   "editor.formatOnSave": true,
   "editor.codeActionsOnSave": {
     "source.fixAll.eslint": true

packages/app/load.envs.js

@@ -4,7 +4,7 @@ const { readFileSync } = require('fs');
 
 function getVersion() {
   const packageJson = JSON.parse(
-    readFileSync(resolve(__dirname, './package.json')).toString(),
+    readFileSync(resolve(__dirname, './package.json')).toString()
   );
   return {
     version: packageJson.version,
@@ -33,8 +33,8 @@ function getPublicEnvs() {
   const WHITELIST = ['NODE_ENV', 'PUBLIC_URL'];
   return Object.fromEntries(
     Object.entries(process.env).filter(([key]) =>
-      WHITELIST.some((k) => k === key || key.match(/^VITE_/)),
-    ),
+      WHITELIST.some((k) => k === key || key.match(/^VITE_/))
+    )
   );
 }
 

packages/app/playwright/commons/seedWallet.ts

@@ -21,14 +21,14 @@ export async function seedWallet(address: string, amount: BN) {
     Address.fromString(address),
     amount,
     BaseAssetId,
-    { gasPrice, gasLimit },
+    { gasPrice, gasLimit }
   );
   await transfETH.wait();
   const transfAsset = await genesisWallet.transfer(
     Address.fromString(address),
     amount,
     ALT_ASSET.assetId,
-    { gasPrice, gasLimit },
+    { gasPrice, gasLimit }
   );
   await transfAsset.wait();
 }

packages/app/playwright/commons/text.ts

@@ -5,7 +5,7 @@ export async function hasText(
   page: Page,
   text: string | RegExp,
   position: number = 0,
-  timeout: number = 5000,
+  timeout: number = 5000
 ) {
   const textFound = page.getByText(text).nth(position);
   await expect(textFound).toHaveText(text, {

packages/app/playwright/crx/crx.test.ts

@@ -180,7 +180,7 @@ test.describe('FuelWallet Extension', () => {
 
       async function createAccountFromPrivateKey(
         privateKey: string,
-        name: string,
+        name: string
       ) {
         await waitWalletToLoad(popupPage);
         await getByAriaLabel(popupPage, 'Accounts').click();
@@ -315,7 +315,7 @@ test.describe('FuelWallet Extension', () => {
           return window.fuel.currentAccount();
         });
         await expect(currentAccountPromise).rejects.toThrowError(
-          'address is not authorized for this connection.',
+          'address is not authorized for this connection.'
         );
       });
     });
@@ -328,7 +328,7 @@ test.describe('FuelWallet Extension', () => {
           async ([address, message]) => {
             return window.fuel.signMessage(address, message);
           },
-          [address, message],
+          [address, message]
         );
       }
 
@@ -346,7 +346,7 @@ test.describe('FuelWallet Extension', () => {
         const messageSigned = await signedMessagePromise;
         const addressSigner = Signer.recoverAddress(
           hashMessage(message),
-          messageSigned,
+          messageSigned
         );
 
         // Verify signature is from the account selected
@@ -361,28 +361,28 @@ test.describe('FuelWallet Extension', () => {
       await test.step('Signed message using authorized Account 3', async () => {
         const authorizedAccount = await getAccountByName(
           popupPage,
-          'Account 3',
+          'Account 3'
         );
         await approveMessageSignCheck(authorizedAccount);
       });
 
       await test.step('Signed message using authorized Account 4 (from Private Key)', async () => {
         const authorizedAccount = await getAccountByName(
           popupPage,
-          'Account 4',
+          'Account 4'
         );
         await approveMessageSignCheck(authorizedAccount);
       });
 
       await test.step('Throw on not Authorized Account', async () => {
         const notAuthorizedAccount = await getAccountByName(
           popupPage,
-          'Account 2',
+          'Account 2'
         );
         const signedMessagePromise = signMessage(notAuthorizedAccount.address);
 
         await expect(signedMessagePromise).rejects.toThrowError(
-          'address is not authorized for this connection.',
+          'address is not authorized for this connection.'
         );
       });
     });
@@ -392,15 +392,15 @@ test.describe('FuelWallet Extension', () => {
       async function transfer(
         senderAddress: string,
         receiverAddress: string,
-        amount: number,
+        amount: number
       ) {
         return blankPage.evaluate(
           async ([senderAddress, receiverAddress, amount]) => {
             const receiver = window.fuel.utils.createAddress(
-              receiverAddress as string,
+              receiverAddress as string
             );
             const wallet = await window.fuel!.getWallet(
-              senderAddress as string,
+              senderAddress as string
             );
 
             // TODO: remove this gas config once SDK fixes and start with correct values
@@ -412,18 +412,18 @@ test.describe('FuelWallet Extension', () => {
               receiver,
               Number(amount),
               undefined,
-              { gasPrice, gasLimit },
+              { gasPrice, gasLimit }
             );
             const result = await response.waitForResult();
             return result.status;
           },
-          [senderAddress, receiverAddress, String(amount)],
+          [senderAddress, receiverAddress, String(amount)]
         );
       }
 
       async function approveTxCheck(senderAccount: Account) {
         const provider = await Provider.create(
-          process.env.VITE_FUEL_PROVIDER_URL,
+          process.env.VITE_FUEL_PROVIDER_URL
         );
         const receiverWallet = Wallet.generate({
           provider,
@@ -437,7 +437,7 @@ test.describe('FuelWallet Extension', () => {
         const transferStatus = transfer(
           senderAccount.address,
           receiverWallet.address.toString(),
-          AMOUNT_TRANSFER,
+          AMOUNT_TRANSFER
         );
 
         // Wait for approve transaction page to show
@@ -449,7 +449,7 @@ test.describe('FuelWallet Extension', () => {
         await hasText(approveTransactionPage, /0\.0000001.ETH/i);
         await waitAriaLabel(
           approveTransactionPage,
-          senderAccount.address.toString(),
+          senderAccount.address.toString()
         );
         await hasText(approveTransactionPage, /Confirm before approving/i);
         await getButtonByText(approveTransactionPage, /Approve/i).click();
@@ -467,26 +467,26 @@ test.describe('FuelWallet Extension', () => {
       await test.step('Send transfer using authorized Account 3', async () => {
         const authorizedAccount = await getAccountByName(
           popupPage,
-          'Account 3',
+          'Account 3'
         );
         await approveTxCheck(authorizedAccount);
       });
 
       await test.step('Send transfer using authorized Account 4 (from Private Key)', async () => {
         const authorizedAccount = await getAccountByName(
           popupPage,
-          'Account 4',
+          'Account 4'
         );
         await approveTxCheck(authorizedAccount);
       });
 
       await test.step('Send transfer should block unauthorized account', async () => {
         const nonAuthorizedAccount = await getAccountByName(
           popupPage,
-          'Account 2',
+          'Account 2'
         );
         const provider = await Provider.create(
-          process.env.VITE_FUEL_PROVIDER_URL,
+          process.env.VITE_FUEL_PROVIDER_URL
         );
         const receiverWallet = Wallet.generate({
           provider,
@@ -500,11 +500,11 @@ test.describe('FuelWallet Extension', () => {
         const transferStatus = transfer(
           nonAuthorizedAccount.address,
           receiverWallet.address.toString(),
-          AMOUNT_TRANSFER,
+          AMOUNT_TRANSFER
         );
 
         await expect(transferStatus).rejects.toThrowError(
-          'address is not authorized for this connection.',
+          'address is not authorized for this connection.'
         );
       });
     });
@@ -522,7 +522,7 @@ test.describe('FuelWallet Extension', () => {
           async ([asset]) => {
             return window.fuel.addAsset(asset);
           },
-          [asset],
+          [asset]
         );
       }
 
@@ -542,7 +542,7 @@ test.describe('FuelWallet Extension', () => {
           async ([asset]) => {
             return window.fuel.addAssets(asset);
           },
-          [assets],
+          [assets]
         );
       }
 
@@ -562,7 +562,7 @@ test.describe('FuelWallet Extension', () => {
           async ([network]) => {
             return window.fuel.addNetwork(network);
           },
-          [network],
+          [network]
         );
       }
 

packages/app/playwright/e2e/Accounts.test.ts

@@ -55,7 +55,7 @@ test.describe('Account', () => {
     await hasText(page, data.accounts[0].name);
     await getByAriaLabel(
       page,
-      `Account Actions ${data.accounts[0].name}`,
+      `Account Actions ${data.accounts[0].name}`
     ).click();
     await getByAriaLabel(page, `Edit ${data.accounts[0].name}`).click();
     await hasText(page, /Edit/i);
@@ -75,7 +75,7 @@ test.describe('Account', () => {
     await hasText(page, data.accounts[0].name);
     await getByAriaLabel(
       page,
-      `Account Actions ${data.accounts[0].name}`,
+      `Account Actions ${data.accounts[0].name}`
     ).click();
     await getByAriaLabel(page, `Export ${data.accounts[0].name}`).click();
 
@@ -94,7 +94,7 @@ test.describe('Account', () => {
     await hasText(page, data.accounts[1].name);
     await getByAriaLabel(
       page,
-      `Account Actions ${data.accounts[1].name}`,
+      `Account Actions ${data.accounts[1].name}`
     ).click();
     await getByAriaLabel(page, `Hide ${data.accounts[1].name}`).click();
     await hasText(page, 'Show hidden accounts');
@@ -103,7 +103,7 @@ test.describe('Account', () => {
     await hasText(page, data.accounts[1].name);
     await getByAriaLabel(
       page,
-      `Account Actions ${data.accounts[1].name}`,
+      `Account Actions ${data.accounts[1].name}`
     ).click();
     await getByAriaLabel(page, `Unhide ${data.accounts[1].name}`).click();
     await page.getByText('Show hidden accounts').isHidden();
@@ -117,14 +117,14 @@ test.describe('Account', () => {
     await hasText(page, data.accounts[1].name);
     await getByAriaLabel(
       page,
-      `Account Actions ${data.accounts[1].name}`,
+      `Account Actions ${data.accounts[1].name}`
     ).click();
     await getByAriaLabel(page, `Hide ${data.accounts[1].name}`).click();
     await hasText(page, 'Show hidden accounts');
     await page.getByText(data.accounts[1].name).isHidden();
     await getByAriaLabel(
       page,
-      `Account Actions ${data.accounts[0].name}`,
+      `Account Actions ${data.accounts[0].name}`
     ).click();
     await getByAriaLabel(page, `Hide ${data.accounts[0].name}`).isHidden();
   });
@@ -136,7 +136,7 @@ test.describe('Account', () => {
     await hasText(page, data.accounts[0].name);
     await getByAriaLabel(
       page,
-      `Account Actions ${data.accounts[0].name}`,
+      `Account Actions ${data.accounts[0].name}`
     ).click();
     await getByAriaLabel(page, `Export ${data.accounts[0].name}`).click();
 

packages/app/playwright/e2e/Asset.test.ts

@@ -27,7 +27,7 @@ test.describe('Asset', () => {
     await getByAriaLabel(page, 'Asset name').type(CUSTOM_ASSET.name);
     await getByAriaLabel(page, 'Asset symbol').type(CUSTOM_ASSET.symbol);
     await getByAriaLabel(page, 'Asset decimals').type(
-      String(CUSTOM_ASSET.decimals),
+      String(CUSTOM_ASSET.decimals)
     );
     await getByAriaLabel(page, 'Asset image Url').type(CUSTOM_ASSET.imageUrl);
     await getByAriaLabel(page, 'Save Asset').click();

packages/app/playwright/e2e/RecoverWallet.test.ts

@@ -75,7 +75,7 @@ test.describe('RecoverWallet', () => {
     await getButtonByText(page, /Next: Seed Phrase/i).click();
 
     await getByAriaLabel(page, 'Select format').selectOption(
-      'I have a 24 words Seed Phrase',
+      'I have a 24 words Seed Phrase'
     );
 
     /** Copy words to clipboard area */

packages/app/playwright/e2e/ReportError.test.ts

@@ -33,7 +33,7 @@ test.describe('ReportError', () => {
 
     await hasText(page, /Unexpected errors detected/i);
     await expect(page.locator(`textarea[name="reports"]`)).toHaveText(
-      /componentStack/i,
+      /componentStack/i
     );
 
     // get errors from indexedDB
@@ -64,7 +64,7 @@ test.describe('ReportError', () => {
     await reload(page);
     await hasText(page, /Unexpected errors detected/i);
     await expect(page.locator(`textarea[name="reports"]`)).toHaveText(
-      /Test Error/i,
+      /Test Error/i
     );
 
     // report error
@@ -91,7 +91,7 @@ test.describe('ReportError', () => {
 
     await hasText(page, /Unexpected errors detected/i);
     await expect(page.locator(`textarea[name="reports"]`)).toHaveText(
-      /Test Error/i,
+      /Test Error/i
     );
 
     // report error