Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

u256 shifts operators #4928

Merged
merged 6 commits into from
Aug 14, 2023
Merged

u256 shifts operators #4928

merged 6 commits into from
Aug 14, 2023

Conversation

xunilrj
Copy link
Contributor

@xunilrj xunilrj commented Aug 9, 2023 •
edited
Loading

Description

This PR is part of #4794.

It implements left and right shifts. These have a little difference because the rhs is always u64, which means that the WQOP used the rhs is not indirect.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@xunilrj xunilrj mentioned this pull request Aug 9, 2023
Closed
19 tasks
@xunilrj xunilrj requested review from anton-trunov and a team August 9, 2023 11:57
@xunilrj xunilrj enabled auto-merge (squash) August 9, 2023 20:20
IGI-111
IGI-111 reviewed Aug 11, 2023
View reviewed changes
sway-ir/src/verify.rs Outdated Show resolved Hide resolved
IGI-111
IGI-111 reviewed Aug 11, 2023
View reviewed changes
sway-ir/src/verify.rs Outdated Show resolved Hide resolved
@IGI-111 IGI-111 requested a review from a team August 11, 2023 10:00
@xunilrj xunilrj requested a review from IGI-111 August 11, 2023 11:05
@IGI-111 IGI-111 requested a review from a team August 14, 2023 09:17
@xunilrj xunilrj merged commit c76f174 into master Aug 14, 2023
@xunilrj xunilrj deleted the xunilrj/u256-shifts branch August 14, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IGI-111 IGI-111 IGI-111 approved these changes

@tritao tritao tritao approved these changes

@anton-trunov anton-trunov Awaiting requested review from anton-trunov

Assignees

@xunilrj xunilrj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xunilrj @tritao @anton-trunov @IGI-111