Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix u256 at contract storage #5139

Merged
merged 5 commits into from
Sep 26, 2023
Merged

fix u256 at contract storage #5139

merged 5 commits into from
Sep 26, 2023

Conversation

xunilrj
Copy link
Contributor

@xunilrj xunilrj commented Sep 22, 2023 •
edited
Loading

Description

This PR is part of #4794. u256 was not being considered a reference type which was creating some issues when using it in storage. This PR fixes this problem.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@xunilrj xunilrj self-assigned this Sep 22, 2023
@xunilrj xunilrj mentioned this pull request Sep 22, 2023
Closed
19 tasks
@xunilrj xunilrj marked this pull request as ready for review September 23, 2023 06:42
@xunilrj xunilrj requested a review from a team September 24, 2023 12:38
anton-trunov
anton-trunov previously approved these changes Sep 25, 2023
View reviewed changes
@xunilrj xunilrj requested a review from a team September 25, 2023 11:00
tritao
tritao previously approved these changes Sep 25, 2023
View reviewed changes
@xunilrj xunilrj dismissed stale reviews from tritao and anton-trunov via 4c9e8c1 September 25, 2023 12:42
@xunilrj xunilrj force-pushed the xunilrj/u256_storage branch from 02f6800 to 4c9e8c1 Compare September 25, 2023 12:42
@xunilrj
Copy link
Contributor Author

xunilrj commented Sep 25, 2023

@anton-trunov @tritao Do you mind approving this again? I had to rebase it.

@IGI-111 IGI-111 merged commit 21c48d6 into master Sep 26, 2023
@IGI-111 IGI-111 deleted the xunilrj/u256_storage branch September 26, 2023 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IGI-111 IGI-111 IGI-111 approved these changes

@anton-trunov anton-trunov anton-trunov approved these changes

@tritao tritao tritao left review comments

Assignees

@xunilrj xunilrj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xunilrj @tritao @anton-trunov @IGI-111