-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deprecated attribute #5142
deprecated attribute #5142
Conversation
Reminder to ping #4779 when this is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice minimal implementation of deprecated
! Just a few minor remarks from my side but otherwise LGTM
Since the |
I can do it. Do we have a guide I can follow? |
4a518a1
to
ff2f531
Compare
Great thanks! The guidelines are at the moment only in the RFC: https://github.com/FuelLabs/sway-rfcs/blob/master/rfcs/0011-expressive-diagnostics.md#wording-guidelines I'll bring them into the sway-error README.md and expand with examples. It is also good to take existing warnings in the Let me know if you have questions. We will all anyhow need a bit of practice there 😄 |
Description
This PR is part of #4794. It is the minimum implementation for deprecation. Pretty much only what was needed for deprecating
U256
.It also minimally implements
#[allow(deprecated)]
.Checklist
Breaking*
orNew Feature
labels where relevant.