Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes array oob on reassignment. #6819

Merged
merged 3 commits into from
Jan 9, 2025
Merged

Conversation

esdrubal
Copy link
Contributor

@esdrubal esdrubal commented Jan 7, 2025

Description

When using literal on array reasignement we were not checking the array length. We now throw an array oob error in this case.

Fixes #6393

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@esdrubal esdrubal added compiler General compiler. Should eventually become more specific as the issue is triaged compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen labels Jan 7, 2025
@esdrubal esdrubal self-assigned this Jan 7, 2025
When using literal on array reasignement we were not checking the array length.
We now throw an array oob error in this case.

Fixes #6393
@esdrubal esdrubal force-pushed the esdrubal/array_oob_reassignment branch from 73ff74d to ec08cd4 Compare January 7, 2025 17:19
Copy link

codspeed-hq bot commented Jan 7, 2025

CodSpeed Performance Report

Merging #6819 will not alter performance

Comparing esdrubal/array_oob_reassignment (d7199fe) with master (561007d)

Summary

✅ 22 untouched benchmarks

@esdrubal esdrubal marked this pull request as ready for review January 8, 2025 09:13
@esdrubal esdrubal requested a review from a team as a code owner January 8, 2025 09:13
@tritao tritao merged commit faf399e into master Jan 9, 2025
41 checks passed
@tritao tritao deleted the esdrubal/array_oob_reassignment branch January 9, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen compiler General compiler. Should eventually become more specific as the issue is triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Out-of-bounds Inconsistency
3 participants