Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add erroneously missing #[test()] attribute #6824

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

SwayStar123
Copy link
Collaborator

@SwayStar123 SwayStar123 commented Jan 9, 2025

Description

A few bytes tests are erroneously missing the test attribute, meaning they are not actually run.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@SwayStar123 SwayStar123 self-assigned this Jan 9, 2025
@SwayStar123 SwayStar123 added bug Something isn't working testing General testing labels Jan 9, 2025
@SwayStar123 SwayStar123 marked this pull request as ready for review January 9, 2025 13:34
@SwayStar123 SwayStar123 requested a review from a team as a code owner January 9, 2025 13:34
@K1-R1 K1-R1 requested a review from a team January 9, 2025 14:02
@IGI-111 IGI-111 merged commit 1192b3f into master Jan 10, 2025
39 checks passed
@IGI-111 IGI-111 deleted the swaystar123/add-test-attribute-bytes-tests branch January 10, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working testing General testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants