Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[asmgen] pushing / popping registers for call should handle all def'd regs #6826

Merged
merged 6 commits into from
Jan 18, 2025
Merged

[asmgen] pushing / popping registers for call should handle all def'd regs #6826

merged 6 commits into from
Jan 18, 2025

Conversation

vaivaswatha
Copy link
Contributor

Fixes #6814

@vaivaswatha vaivaswatha self-assigned this Jan 10, 2025
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 10, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #6826 will not alter performance

Comparing vaivaswatha/issue6814 (2f8873b) with master (9cd1b39)

Summary

✅ 22 untouched benchmarks

@vaivaswatha vaivaswatha marked this pull request as ready for review January 14, 2025 09:28
@vaivaswatha vaivaswatha requested a review from a team as a code owner January 14, 2025 09:28
@IGI-111 IGI-111 requested a review from a team January 15, 2025 14:10
jjcnn
jjcnn approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@jjcnn jjcnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vaivaswatha vaivaswatha merged commit a67e9a9 into master Jan 18, 2025
41 checks passed
@vaivaswatha vaivaswatha deleted the vaivaswatha/issue6814 branch January 18, 2025 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjcnn jjcnn jjcnn approved these changes

@IGI-111 IGI-111 IGI-111 approved these changes

Assignees

@vaivaswatha vaivaswatha

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect PushA PopA Mask Calculation
3 participants
@vaivaswatha @IGI-111 @jjcnn