Added Asynchronous Success function support #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If asyncSuccess is true then the success function will be called with the controller(this) as the first parameter and the close dialog function as the second parameter. This allows you to conditionally continue. In my case I needed the success to not close the dialog if perhaps the data entered in the dialog was invalid. Also I needed to validate asynchronously. FYI if this is not something fundoo-solutions doesn't want in createDialog thats fine. I just needed it for my project. :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If asyncSuccess is true then the success function will be called with the controller(this) as the first parameter and the close dialog function as the second parameter.
This allows you to conditionally continue. In my case I needed the success to not close the dialog if perhaps the data entered in the dialog was invalid. Also I needed to validate asynchronously.
FYI if this is not something fundoo-solutions doesn't want in createDialog thats fine. I just needed it for my project. :-)