Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Restored and fixed Discord RPC support #2330

Closed
wants to merge 8 commits into from
Closed

[FEATURE] Restored and fixed Discord RPC support #2330

wants to merge 8 commits into from

Conversation

AltronMaxX
Copy link

The title speaks for itself

@ninjamuffin99
Copy link
Member

note for future self or eric:

  • if we merge this internally, we need to make sure that it DOESN'T boot up when compiling / testing in debug mode / -DGITHUB_BUILD so we don't accidentally have current work being streamed to our discord accounts!

@ninjamuffin99 ninjamuffin99 added this to the 0.3.3 milestone May 9, 2024
@AltronMaxX
Copy link
Author

Looks like it not happen in 0.3.3 Xd

@ninjamuffin99 ninjamuffin99 modified the milestones: 0.3.3, 0.3.4 May 15, 2024
@EliteMasterEric EliteMasterEric changed the title Restored and fixed Discord RPC support [FEATURE] Restored and fixed Discord RPC support May 22, 2024
@ninjamuffin99 ninjamuffin99 modified the milestones: 0.3.4, 0.4.0 May 24, 2024
@AltronMaxX AltronMaxX force-pushed the feature/discord-rpc branch from f4840be to ffdf4f7 Compare May 29, 2024 05:00
@EliteMasterEric EliteMasterEric added the type: enhancement Involves an enhancement or new feature. label May 30, 2024
@EliteMasterEric EliteMasterEric removed this from the 0.4.0 milestone Jun 7, 2024
@EliteMasterEric EliteMasterEric added status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. and removed reviewing-internally labels Jun 16, 2024
@EliteMasterEric
Copy link
Member

We definitely want to get this into an update at some point (and we'll make sure it involves this PR so you get credited).

@EliteMasterEric EliteMasterEric mentioned this pull request Jun 17, 2024
Open
@EliteMasterEric EliteMasterEric added status: reviewing internally Under consideration and testing. and removed status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. labels Jun 27, 2024
@EliteMasterEric EliteMasterEric added the size: medium A medium pull request with 100 or fewer changes. label Jul 11, 2024
@EliteMasterEric EliteMasterEric deleted the branch FunkinCrew:develop July 12, 2024 00:59
@AltronMaxX
Copy link
Author

Any updates?

@EliteMasterEric
Copy link
Member

I almost forgot this existed, LOL!

Thanks for updating this today, I will look into merging it

@EliteMasterEric
Copy link
Member

EliteMasterEric commented Sep 19, 2024 •
edited
Loading

Another update

This doesn't work, so I'm working on rewriting things myself

EDIT: Got it working by myself and this PR didn't end up helping so I'm going to close it as not planned.

@AltronMaxX
Copy link
Author

:(

@AltronMaxX AltronMaxX deleted the feature/discord-rpc branch September 21, 2024 21:22
AltronMaxX added a commit to Altronix-Team/FNF-AltronixEngine that referenced this pull request Sep 21, 2024
@AltronMaxX
whoops, I think I know why my pr wont work
853f0c6 
RIP FunkinCrew/Funkin#2330
AltronMaxX added a commit to Altronix-Team/FNF-AltronixEngine that referenced this pull request Sep 21, 2024
@AltronMaxX
Ok, lets use hxdiscord_rpc
2761967 
RIP FunkinCrew/Funkin#2330
@Hundrec Hundrec removed type: enhancement Involves an enhancement or new feature. status: reviewing internally Under consideration and testing. size: medium A medium pull request with 100 or fewer changes. labels Jan 22, 2025
@AbnormalPoof AbnormalPoof added the status: rejected Issue did not pass review or PR cannot be approved. label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EliteMasterEric EliteMasterEric Awaiting requested review from EliteMasterEric

Assignees
No one assigned
Labels
status: rejected Issue did not pass review or PR cannot be approved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AltronMaxX @ninjamuffin99 @EliteMasterEric @AbnormalPoof @Hundrec