[ENHANCEMENT] Chart Editor: Offset the waveform visually by it's vocal offset #3353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that it is tied to both of them
|
The big issue still is the offset toolbox is very buggy, same with offsets in general as instrumental offsets can cause various issues in the game. This is just a QOL |
|
my b I accidently deleted this while cleaning |
ninjamuffin99
force-pushed
the
develop
branch
2 times, most recently
from
e0b1b01 to
410cfe9
Compare
AbnormalPoof
added
the
status: rejected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR close any issues? If so, link them below.
N/A
Briefly describe the issue(s) fixed.
Before you couldn't tell if the offset was even doing anything visually to vocals, now it shows an actual change on the main view.
Include any relevant screenshots or videos.