Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Mostly Soft-Coded Character Select Menu's GFs #3371

Closed
wants to merge 4 commits into from
Closed

[ENHANCEMENT] Mostly Soft-Coded Character Select Menu's GFs #3371

wants to merge 4 commits into from

Conversation

KoloInDaCrib
Copy link
Contributor

Does this PR close any issues? If so, link them below.

N/A

Briefly describe the issue(s) fixed.

Added a field to PlayerData's PlayerCharSelectData, "assignedGF", which allows for any defined Girlfriend to be assigned to the Character in the Character Select Substate. (like how Nene should be assigned to Pico and GF to BF). If null, "gf" value would be loaded instead and thus, default GF would be loaded.

Replaces the hardcoded switch() function in (CharSelectGF)[.source/funkin/ui/charSelect/CharSelectGF.hx].

The only non-softcoded part is the visual side of Nene's speaker analyzer, that would probably require turning GFs into scriptable objects

Include any relevant screenshots or videos.

N/A

fixes the bug with the percent being overriden when the song has the same letter rank but lower percent (eg. E Rank with 99% being overriden by E Rank with 93%)
@EliteMasterEric EliteMasterEric added the status: pending triage Awaiting review. label Sep 19, 2024
@EliteMasterEric
Copy link
Member

EliteMasterEric commented Sep 19, 2024

I pulled this internally and then immediately reworked the whole thing.

I'll still merge it so you'll be credited but like none of your actual code is there anymore sorry lol

EDIT: In case people are wondering, the visualizer is now a boolean flag in the character data (true/false) so it's hardcoded BUT if your custom GF character includes the right animations you can enable it on them.

@EliteMasterEric EliteMasterEric added status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. and removed status: pending triage Awaiting review. labels Sep 19, 2024
@EliteMasterEric EliteMasterEric added this to the 0.5.1 milestone Sep 19, 2024
@EliteMasterEric EliteMasterEric added type: enhancement Involves an enhancement or new feature. topic: mods Related to the creation or use of mods. labels Sep 19, 2024
@EliteMasterEric EliteMasterEric self-assigned this Sep 19, 2024
@KoloInDaCrib
Copy link
Contributor Author

I pulled this internally and then immediately reworked the whole thing.

I'll still merge it so you'll be credited but like none of your actual code is there anymore sorry lol

EDIT: In case people are wondering, the visualizer is now a boolean flag in the character data (true/false) so it's hardcoded BUT if your custom GF character includes the right animations you can enable it on them.

Works for me thanks lol

@KoloInDaCrib KoloInDaCrib closed this by deleting the head repository Sep 19, 2024
@Hundrec
Copy link
Collaborator

Hundrec commented Sep 19, 2024

Hey! Did you mean to close this?

@KoloInDaCrib
Copy link
Contributor Author

Yes, actually, since it was implemented, and I figured that closing this could keep the pr's a bit more organized

also I fucked up the fork and wanted to start with a new one lol

@EliteMasterEric EliteMasterEric removed their assignment Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. topic: mods Related to the creation or use of mods. type: enhancement Involves an enhancement or new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants