Chart editor - Don't move the stuff if it wasn't actually moved #4185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
status: pending triage
Lasercar
force-pushed
the
chart-editor-don't-move-stuff-if-it-wasn't-moved
branch
from
b295037 to
d52f750
Compare
Lasercar
changed the title
Lasercar
changed the title
AbnormalPoof
added
type: minor bug
Lasercar
force-pushed
the
chart-editor-don't-move-stuff-if-it-wasn't-moved
branch
from
27250fe to
4976b56
Compare
Lasercar
force-pushed
the
chart-editor-don't-move-stuff-if-it-wasn't-moved
branch
from
4976b56 to
3b4b776
Compare
|
Oh whoops, I already linked this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR close any issues? If so, link them below.
Fixes #3761
Briefly describe the issue(s) fixed.
When you move a bunch of items or notes and move them back into the same position and release, it removes the selection boxes on the notes for some reason.
To fix this, the code now returns if they weren't actually moved. This doesn't fix actually fix the issue in the code, it just bypasses it. I have no clue where it happens, but it has something to do with when the move command is performed but the notes don't actually need to move at all, and something note specific because it doesn't happen to events when moved but not actually moved.
Include any relevant screenshots or videos.
2025-02-19.23-59-50.mp4
Wait, that's weird, the move events command can still preform.Ah, it's because dragDistanceColumns is always 8. I'll make an additional change for that to keep the functionally the same.Done.