Fix alpha not being applied correctly on adjustColor.frag #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When trying to set alpha on a sprite that uses this shader (e.x. Darnell BF Mix), the alpha just doesn't get applied, it remains as if it is still set to 1 This fixes that issue
|
Likely this will happen on other shaders too, so might be good to sweep through all the shaders and make sure it applies to all of them? (Also, colorTransforms won't work so might be good to look into using flixel_texture2d?) |
Remind me to do that later when it isn't 2:12am ❤️ |
EliteMasterEric
added
the
status: pending triage
|
Can we get a before and after on this to confirm this doesn't mess anything up visually? |
EliteMasterEric
added
status: needs clarification
Before: After: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally, when trying to set alpha on a sprite that uses this shader (e.x. Darnell BF Mix), the alpha just doesn't get applied, it remains as if it is still set to 1
This pull request should fix that
Tested in 0.5.0 (Windows Desktop)