-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Potential Off-Hand Duplication fix. #67
base: master
Are you sure you want to change the base?
Conversation
This is a potential (I am saying potential because I cant compile the plugin to test it) fix for the off-hand duplication method present in this plugin. Please test before considering merging.
Yes I am aware of this most of the maven repositories he is using aren't working and therefore even I was unable to compile it. There are workarounds but im not too sure.
I will look into it. I am very busy atm but we will see.
Will update :)
Hold an easel in your offhand and right click on the ground. It isn't taking the easel out because its looking for the item in their main hand (he didn't take into account that the easel is in the second/off hand). |
I'm able to compile the main upstream source by removing many of the optional dependencies from the pom and compatibility modules, such as Residence. As well as compile it against 1.12.2 spigot/bukkit fine after doing so. Doing the same with your commit, it isn't able to find the methods defined so you seem to be missing an important bukkit import. I tried adding
Oh! That's what you meant by off-hand duplication! Yep, can confirm that is a problem. Only seems to happen when your main hand is empty (since you can't place items set in off-hand if you have an item in your main hand as well). However I was also able to experience another issue upon trying to test off-hand issues. If every slot in your inventory is full and you have 1 item in your off-hand, upon sitting on an easel, the off-hand item is brought into the artkit inventory when sitting.
This works with any item in your off-hand. I can't seem to reproduce any issues with it duplicating the item, only losing the item. As well as this only happens when your entire inventory is full.
Would be much appreciated! |
Regarding the deprecated recipe API use;
|
@mibby Do you have a discord account or spigot account that I can message you about this? |
Yeah I will work on a full fix/update soon when I have the time. Got a bunch of assignments and exams to study for and complete first. After that I'll fix it. Its a relatively simple fix theoretically. Just need to know how to properly compile it, to test. |
I know how to fix the issue as it is quite easy. I am just having troubles compiling. |
What issues are you having compiling? I'm able to compile the main upstream branch fine. If you can push the commit to fix the issue, I can check and see if I can compile your fork with some of the changes noted here LogGits@8193e77#commitcomment-26954834. |
This is a potential (I am saying potential because I cant compile the plugin to test it) fix for the off-hand duplication method present in this plugin. Please test before considering merging.